919932 - Clean up multiple instances of teardownModule found in the same test

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andrei Eftimie]

We have multiple instances of teardownModule across several tests.

This was probably introduced during the latest merge (I am assuming it got merged without a conflict, and we missed it).

Lets get this fixed quickly as it breaks some test in Beta.

Please check all branches for this duplicate content.

Comment 1

[Andrei Eftimie]

These were introduced in the previous merge from 5th August:
http://hg.mozilla.org/qa/mozmill-tests/diff/eed4d1de6f98/tests/functional/restartTests/testAddons_enableDisableExtension/test1.js

Comment 2

[mario garbi]

Attachment: teardownModuleDuplicates.patch

Here we remove the duplicated teardownModule().

Comment 3

[mario garbi]

Forgot to specify that the patch is for Beta as I couldn't find duplicates in upper branches (Aurora and Nightly).

Comment 4

[Andrei Eftimie]

Comment on attachment 809078 [details] [diff] [review]
teardownModuleDuplicates.patch

Review of attachment 809078 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, 
I couldn't find any other instances.

Linux all green:
http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee6972191f6ba8

On OSX I still have 2 failures:
http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee697219205c9c

But they appear unrelated as I also see them prior to this patch:
http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee69721921d4d1

I'll investigate them separately.

Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/dd86dbb12ca3 (mozilla-beta)

Mario, please see if this needs backporting on other branches.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Andrei Eftimie from comment #4)
> On OSX I still have 2 failures:
> http://mozmill-crowd.blargon7.com/#/functional/report/
> 837c1e0f361ac93453ee697219205c9c

Because you are using mozmill 2.0rc5 and not 2.0rc6. Please check your environment.

Comment 6

[mario garbi]

Attachment: teardownModuleDuplicates_RELEASE.patch

Backport to Release branch

http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee697219226ef9
http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee69721922f55a

Comment 7

[mario garbi]

The release patch also applies cleanly on ESR24.

Comment 8

[mario garbi]

I couldn't find any duplicated on ESR17, setting flags as such.

Comment 9

[Andrei Eftimie]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> (In reply to Andrei Eftimie from comment #4)
> > On OSX I still have 2 failures:
> > http://mozmill-crowd.blargon7.com/#/functional/report/
> > 837c1e0f361ac93453ee697219205c9c
> 
> Because you are using mozmill 2.0rc5 and not 2.0rc6. Please check your
> environment.

Correct. I didn't update mozmill-automation and it always pulled mozmill rc05.
Green testrun now http://mozmill-crowd.blargon7.com/#/functional/report/837c1e0f361ac93453ee69721928fc68

Comment 10

[Andrei Eftimie]

Comment on attachment 809117 [details] [diff] [review]
teardownModuleDuplicates_RELEASE.patch

Review of attachment 809117 [details] [diff] [review]:
-----------------------------------------------------------------

Landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/d7cddff5d1bc (mozilla-release)
http://hg.mozilla.org/qa/mozmill-tests/rev/2e581b989dd7 (mozilla-esr24)