Closed Bug 919945 Opened 10 years ago Closed 10 years ago

Intermittent TEST-UNEXPECTED-FAIL | browser_windowopen_reflows.js | unexpected uninterruptible reflow 'ssi_getWindowDimension@resource:///modules/sessionstore/SessionStore.jsm:3338

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Future
Tracking Flags:
Tracking Status
firefox26 --- unaffected
firefox27 --- unaffected
firefox28 --- unaffected
firefox-esr24 --- unaffected

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [Australis:P-]) 

This seems to happen on OS X debug only so far:

https://tbpl.mozilla.org/php/getParsedLog.php?id=28154284&tree=UX
https://tbpl.mozilla.org/php/getParsedLog.php?id=28250043&tree=UX

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_windowopen_reflows.js | unexpected uninterruptible reflow 'ssi_getWindowDimension@resource:///modules/sessionstore/SessionStore.jsm:3338|@resource:///modules/sessionstore/SessionStore.jsm:1946|ssi_updateWindowFeatures@resource:///modules/sessionstore/SessionStore.jsm:1947|ssi_collectWindowData@resource:///modules/sessionstore/SessionStore.jsm:2093|@resource:///modules/sessionstore/SessionStore.jsm:1981|ssi_forEachBrowserWindow@resource:///modules/sessionstore/SessionStore.jsm:3179|@resource:///modules/sessionstore/SessionStore.jsm:1977|@resource:///modules/sessionstore/SessionStore.jsm:275|@resource://app/modules/sessionstore/SessionSaver.jsm:194|@resource://app/modules/sessionstore/SessionSaver.jsm:249|@resource://gre/modules/Promise.jsm:572|@resource://gre/modules/Promise.jsm:354|'

Looking at the stack, I'm guessing this is a race condition where a newly opened window gets opened just as some timer fires in sessionstore that investigates all the windows to collect session data, causing a reflow in the window that's still in the process of opening. Tim, does that sound plausible?
Flags: needinfo?(ttaubert)
Yes, totally. If some test that runs before browser_windowopen_reflow.js does something that invalidates session state - and that is very likely - we will schedule a data collection. If the data collection happens at the wrong time it will cause a reflow.

This is related to bug 892154, that no one is currently working one. Just like the reflow test for tabopen you should add this to the list of known reflows.
Flags: needinfo?(ttaubert)
(In reply to Tim Taubert [:ttaubert] from comment #1)
> Yes, totally. If some test that runs before browser_windowopen_reflow.js
> does something that invalidates session state - and that is very likely - we
> will schedule a data collection. If the data collection happens at the wrong
> time it will cause a reflow.
> 
> This is related to bug 892154, that no one is currently working one. Just
> like the reflow test for tabopen you should add this to the list of known
> reflows.

Egh, don't know why I took so long to finally do this.

https://hg.mozilla.org/projects/ux/rev/c9c57de74376
Blocks: australis-cust
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P-]
Assignee: nobody → gijskruitbosch+bugs
Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.