Closed
Bug 919968
Opened 11 years ago
Closed 11 years ago
OdinMonkey doesn't build on NetBSD/amd64 and Solaris/i386
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: jbeich, Unassigned)
References
()
Details
Attachments
(2 files, 1 obsolete file)
2.15 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
4.26 KB,
patch
|
Details | Diff | Splinter Review |
PkgSrc has a fix.
NetBSD defines struct savefpu in <machine/fpu.h> on amd64 and <machine/npx.h> on i386. fpu.h, unlike npx.h, also exists on other architectures. Solaris defines REG_RIP on amd64 and EIP on i386, they're both aliased to REG_PC. REG_ prefix seems to be reserved for amd64 ABI. http://bxr.su/NetBSD/sys/arch/amd64/include/fpu.h http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/intel/sys/regset.h
Attachment #809105 -
Flags: review?(luke)
Trying to cut down on code duplication in arch-specific ifdefs a bit more.
Attachment #809108 -
Flags: review?(luke)
Comment 3•11 years ago
|
||
Comment on attachment 809105 [details] [diff] [review] missed All the BSDs!
Attachment #809105 -
Flags: review?(luke) → review+
Comment 4•11 years ago
|
||
Comment on attachment 809108 [details] [diff] [review] use PC_sig everywhere >-# if defined(JS_CPU_X64) >- JS_STATIC_ASSERT(sizeof(RIP_sig(context)) == sizeof(void*)); >- return reinterpret_cast<uint8_t**>(&RIP_sig(context)); >-# elif defined(JS_CPU_X86) >- JS_STATIC_ASSERT(sizeof(EIP_sig(context)) == sizeof(void*)); >- return reinterpret_cast<uint8_t**>(&EIP_sig(context)); >-# elif defined(JS_CPU_ARM) >+# if defined(PC_sig) > JS_STATIC_ASSERT(sizeof(PC_sig(context)) == sizeof(void*)); > return reinterpret_cast<uint8_t**>(&PC_sig(context)); > # endif > } Now that there is a single valid case, can you remove the "# if defined(PC_sig)"?
Attachment #809108 -
Flags: review?(luke) → review+
PC_sig ifdef removed as ENABLE_ION is only defined on supported JS_CPU_* archs; carrying over r+
Attachment #809108 -
Attachment is obsolete: true
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f71815d8c59 https://hg.mozilla.org/integration/mozilla-inbound/rev/07ce4364fbec
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4f71815d8c59 https://hg.mozilla.org/mozilla-central/rev/07ce4364fbec
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•