919969 - [Gaia][Settings]Add support of "illegal sim card" state.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Georgia Wang]

See Bug916000, 919967. This is bug for settings to show "illegal SIM"

Comment 1

[Georgia Wang]

Attachment: bug_919969 illegal sim state support , gaia_pull_request_12426

Dear Kaze, could you help review the change?

Comment 2

[Georgia Wang]

Attachment: bug_919969_gaia_pull_request_12426.html

Sorry, previous html is wrong...update the correct one!

Comment 3

[Fabien Cazenave [:kaze]]

Comment on attachment 809749 [details]
bug_919969_gaia_pull_request_12426.html

LGTM, though I’m a bit worried by the word “illegal” which sounds very strong to me — I’d rather expect something like “unauthorized” but I’m no native English speaker. If “illegal SIM” is consistent with iOS or Android that’s fine.

Comment 4

[Georgia Wang]

Compare with Android's behavior : display "No service", the "illegal" is a strong wording.
Base on reviewer's suggestion and our local discussion, we decide to keep illegal state in Gecko but change word to "Unauthorized".

I already update pull-request:

in settings.en-US.properties

simCardIllegal=Unauthorized SIM card

in settings.fr.properties

simCardIllegal=Carte SIM non autorisée

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/e103a6f2b58d0b4614026ac10e936c9219dc3002