[Flatfish] not minimize appWraper bar while swipe up to home gesture is enabled

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

unspecified
Other
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+, b2g-v1.2 fixed)

Details

(Whiteboard: [FT:System-Platform])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
currently appWraper default is minimized and can be tapped or swipe up to show the full appWraper bar.
But when we enabled 'swipe up to home' gesture, the action might be hard to used.

Since we have more estate on tablet, Rob suggest to not minimize appWraper bar while swipe to home gesture is enabled.
(Assignee)

Updated

5 years ago
Assignee: nobody → gasolin
Blocks: 903304
blocking-b2g: --- → koi?
(Assignee)

Comment 3

5 years ago
Created attachment 809757 [details]
pull request redirect to github

tested with customization `"homegesture.enabled": true/false` case , and tried toggle settings in runtime
Attachment #809757 - Flags: review?(alive)
Comment on attachment 809757 [details]
pull request redirect to github

r+ but expect unit test next time.
Attachment #809757 - Flags: review?(alive) → review+
(Assignee)

Comment 5

5 years ago
Thanks.

wait for koi+ since its UX required feature for 1.2
(Assignee)

Updated

5 years ago
status-b2g-v1.2: --- → affected
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [FT:System-Platform]
Needinfo :francis here to get this uplifted if its a flatfish blocker.
Flags: needinfo?(frlee)
(Assignee)

Comment 8

5 years ago
cc Rob to confirm the UX decision
Flags: needinfo?(rmacdonald)

Comment 9

5 years ago
this UX design on flatfish is correct. based on comment3, this setting can be toggle in run time. changed to Koi+.
blocking-b2g: koi? → koi+
Flags: needinfo?(frlee)
Confirming UX decision. This was considered a temporary solution until we can re-design the wrapper.
Flags: needinfo?(rmacdonald)
Uplifted 3809802787e824684a144dc7a03e8795ce4f9f77 to:
v1.2: 3554bea69cdefef631bc209ab3d4421ee2e01516
status-b2g-v1.2: affected → fixed
You need to log in before you can comment on or make changes to this bug.