920049 - gfx/cairo/cairo/src/moz.build :: EXPORTS.cairo file list needs sorting

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

EXPORTS.cairo file list needs sorting.

gfx/cairo/cairo/src/moz.build 
=============================
elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'os2':
    EXPORTS.cairo += [
        'cairo-os2.h',
        'cairo-os2-private.h',
        'cairo-pdf.h',
    ]


 0:02.89 mozbuild.frontend.reader.BuildReaderError: ==============================
 0:02.89 ERROR PROCESSING MOZBUILD FILE
 0:02.89 ==============================
 0:02.89 
 0:02.89 The error occurred while processing the following file:
 0:02.89 
 0:02.89     /local/mozilla/bugs/870406/gfx/cairo/cairo/src/moz.build
 0:02.89 
 0:02.89 The error was triggered on line 66 of this file:
 0:02.89 
 0:02.89     'cairo-pdf.h',
 0:02.89 
 0:02.89 An error was encountered as part of executing the file itself. The error appears to be the fault of the script.
 0:02.89 
 0:02.89 The error as reported by Python is:
 0:02.89 
 0:02.89     ['UnsortedError: An attempt was made to add an unsorted sequence to a list. The incoming list is unsorted starting at element 0. We expected "cairo-os2-private.h" but got "cairo-os2.h"\n']
 0:02.89

Comment 1

[(not currently active) Ted Mielczarek]

I think we determined the OS/2 port is dead, so we could probably just remove this block.

Comment 2

[Peter Weilbacher]

Seconded. The current porting effort at <https://github.com/bitwiseworks/mozilla-os2> is centered around creating its own build system where this section would not be needed anyway.

Comment 3

[:Cykesiopka]

Attachment: bug920049_v1_m-i.patch

Comment 4

[Mike Hommey [:glandium]]

This was actually fixed in bug 921492.