Closed
Bug 920094
Opened 11 years ago
Closed 11 years ago
change default and order of emulated-s3 flag
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: michiel)
Details
Attachments
(1 file)
defaults should be the flag explicitly set to false (so people reading env.dist know it's a variable that can be changed), and the conditional check being "is flag set? If not, is s3_key empty?".
Also, app.js uses the correct check, but middleware.js file uses devmode for emulation check, which is wrong.
Attachment #809255 -
Flags: review?(schranz.m)
Updated•11 years ago
|
Attachment #809255 -
Flags: review?(schranz.m) → review+
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
Updated•11 years ago
|
Assignee: nobody → pomax
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
does this patch still need landing?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
patch landed.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•