920157 - B2G update-source-manifest step shouldn't return code 0 if there was a failure

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

In this log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=28054340&tree=B2g-Inbound

We have:

{
11:21:33     INFO - #####
11:21:33     INFO - ##### Running update-source-manifest step.
11:21:33     INFO - #####
11:21:33     INFO - Running main action method: update_source_manifest
11:21:33     INFO - Reading from file /builds/slave/b2g_b2g-in_nexus-4_dep-0000000/build/sources.xml.original
11:21:33     INFO - Found git_base_url of https://git.mozilla.org/releases/ in manifest.
11:21:33     INFO - Writing to file /builds/slave/b2g_b2g-in_nexus-4_dep-0000000/build/sources.xml
11:21:33     INFO - Running command: ['diff', '-u', '/builds/slave/b2g_b2g-in_nexus-4_dep-0000000/build/sources.xml.original', '/builds/slave/b2g_b2g-in_nexus-4_dep-0000000/build/sources.xml']
11:21:33     INFO - Copy/paste: diff -u /builds/slave/b2g_b2g-in_nexus-4_dep-0000000/build/sources.xml.original /builds/slave/b2g_b2g-in_nexus-4_dep-0000000/build/sources.xml
11:21:33    ERROR - Return code: 0
}

11:21:33    ERROR - Return code: 0

-> either there was an error or there wasn't. This line should either be "INFO - ..." or "ERROR - Return code <non_zero>".

Comment 1

[Ed Morley [:emorley]]

https://hg.mozilla.org/build/mozharness/file/3f61f4af6d8c/scripts/b2g_build.py#l1278