920192 - Conversion underline is not drawn when IME on

Status: VERIFIED WORKSFORME

(DevTools Graveyard :: Scratchpad, defect)

Description

[Alice0775 White]

Attachment: screenshot

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/1fda74e33e06
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20130924030202

Steps To reproduce:
1. Open ScratchPad
2. Type text using IME(IME2010, ATOK maybe)


Actual Results:
Conversion underline is not drawn

Expected Results:
Conversion underline should be drawn

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Axel, Pei, do you know how is our IME support doing?

Comment 2

[Axel Hecht [:Pike]]

Neither. CCing a few more folks. I'll needinfo Ehsan in particular, because he's both intl-savvy and editor-tagged.

Comment 3

[(no longer active)]

Masayuki is the right person to ask about IME...  Is this a regression?

Comment 4

[Alice0775 White]

I found some bugs related to CodeMirror.

https://github.com/marijnh/CodeMirror/pull/1382
https://github.com/marijnh/CodeMirror/issues/1513

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Composition string is selected by a one or more ranges with special selection type for IME. The style of each selection is painted by nsTextFrame.
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsTextFrame.cpp#3681

Comment 6

[bhavana bajaj [:bajaj]]

NI on :anton to help understand if this issue is limited to scratch pad alone or has a wider impact in which case we would track this,

Comment 7

[Anton Kovalyov (:anton)]

Today, this issue is limited to Scratchpad only. Soon, it will become an issue for the Style Editor (bug 919978) and later, when we land live editing in the Debugger, it will become an issue for the Debugger as well.

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Anton Kovalyov (:anton) from comment #7)
> Today, this issue is limited to Scratchpad only. Soon, it will become an
> issue for the Style Editor (bug 919978) and later, when we land live editing
> in the Debugger, it will become an issue for the Debugger as well.

WHat's the plan on resolving this ? Is there a WIP solution to avoid this regression ?

Comment 9

[Anton Kovalyov (:anton)]

(ccing robcee)

There's no active plan mostly because we don't have anyone here who really understands IME. I'm still trying to figure out how to prioritize this. Do people often use IME when writing JavaScript and CSS? Just to be clear, this bug is high up on our list but I'm not sure if it's more important than other high-priority issues. Especially since it affects only minority of components so far.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

In Japan, a lot of websites use Japanese at writing comments. I'm not sure developers want to write comment in our tools, though.

Otherwise, they might need to write Japanese text at setting/initializing string variable/constant. For example, alert("失敗(failed)");

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

On Style Editor, IME may be used for setting a value of content property or quote property.

Comment 12

[Rob Campbell [:rc] (:robcee)]

thanks for the comments, Masayuki.

Once we've gotten CodeMirror in place, we're going to explore some options to get IME implemented in our tools to make editing in CJK easier.

stay tuned! :)

Comment 13

[Anton Kovalyov (:anton)]

Unassigning myself since I'm not *actively* working on this bug just yet.

Comment 14

[bhavana bajaj [:bajaj]]

(In reply to Anton Kovalyov (:anton, @valueof) from comment #9)
> (ccing robcee)
> 
> There's no active plan mostly because we don't have anyone here who really
> understands IME. I'm still trying to figure out how to prioritize this. Do
> people often use IME when writing JavaScript and CSS? Just to be clear, this
> bug is high up on our list but I'm not sure if it's more important than
> other high-priority issues. Especially since it affects only minority of
> components so far.

Given the low user impact here I am not tracking this bug for release, feel free to renominate if needed.

Comment 15

[Makoto Kato [:m_kato]]

Alice-san, does this still occur?  Now we use CodeMirror 5.10.0, so composition state is rendered.

Also, IME's candidate window may be located at top-left when using Microsoft IME due to no API to locate it.

Comment 16

[Alice0775 White]

No longer reproduce.
verified on Noghtly46.0a1, Aurora45.0a2 and Beta44.0b7.