Closed Bug 920270 Opened 11 years ago Closed 11 years ago

Integrate with new Basket API

Categories

(Participation Infrastructure :: Phonebook, defect)

Product:
Participation Infrastructure
Component:
Phonebook
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: hoosteeno, Assigned: dpoirier)

References

Details

(Whiteboard: [kb=1158279] )

A new Basket API has been implemented on the basket side (https://github.com/mozilla/basket#newslookup-user), and we need to integrate with it in order to help the Baseket team improve the quality of service. See bug 902026 for more info.
Hey Justin! I just wanted to check in on this bug. How's integrating the new Basket API going? Is it on the roadmap for Q4?
Jess, it's not on our kanban board right now. Is this bug blocking something?
Oh, ha, yes, I see. Please ignore my last question.
Whiteboard: [kb=1158279]
Assignee: nobody → dpoirier
Status: NEW → ASSIGNED
I'm just wondering whether Mozillians needs that phonebook data it puts in Exact Target? It would simplify things a lot if we didn't need to come up with a token for that.
Flags: needinfo?
(In reply to Dan Poirier [:dpoirier] from comment #4) > I'm just wondering whether Mozillians needs that phonebook data it puts in > Exact Target? It would simplify things a lot if we didn't need to come up > with a token for that. To my knowledge, it does. It doesn't got into Master_Subscribers, but it does go into a different "PHONEBOOK" data extension. Williamr - do you still want this profile info to be in Exact Target for segmenting on certain skills/areas of activity and interest? One point is that this info is old the second after it's passed through at the time of vouching - the new areas of interest are not re=passed through when they are updated/added/deleted in the mozillian's profile. That would need to be a separate bug/feature if that's of interest.
Flags: needinfo? → needinfo?(williamr)
Actually the info does get updated anytime someone updates their profile, including changing their groups, so it should be up to date.
(In reply to Dan Poirier [:dpoirier] from comment #6) > Actually the info does get updated anytime someone updates their profile, > including changing their groups, so it should be up to date. Sweet! Then we're definitely good with keeping this info updated and passing through. Unless WilliamR has any objections (it's his project/platform). WilliamR - is the extra field information passed through from Mozillians.org (groups, interests, etc.) something we want to keep passing through to Exact Target? Dan - when you say "It would simplify things a lot if we didn't need to come up with a token for that." - what token are you having to create? If it's the TOKEN field - that should be the same TOKEN field as in the Master_Subscribers data extension.
Commits pushed to master at https://github.com/mozilla/mozillians https://github.com/mozilla/mozillians/commit/d8d36074090cb78d9ba183b89086df08bf62e9ad Bug 920270 - Change basket-client copy to a submodule https://github.com/mozilla/mozillians/commit/efb12a6f5c0b8f742880193afb240400f5f162e4 Merge pull request #702 from dpoirier/bug-920270-basket-client-submodule Bug 920270 - Change basket-client copy to a submodule
Commits pushed to master at https://github.com/mozilla/mozillians https://github.com/mozilla/mozillians/commit/90de07cf6ecea31237e81fa3b8af7c855c7f0329 Bug 920270 - Change basket-client to a submodule (Use a different directory path to avoid completely confusing git.) https://github.com/mozilla/mozillians/commit/0e51a9ad5de2830c51683d7e69aef5c503d91cb8 Merge pull request #704 from dpoirier/basket-client-submodule Bug 920270 - Change basket-client to a submodule
This will need to be carefully tested before deploying. Some things to make sure work: * When an account is created in mozillians, the person is subscribed to the mailing list * When a person updates their profile, their phonebook data in exact target is updated (including group memberships) * Deleting your profile unsubscribes you
Thanks Dan! To clarify the steps to test: 1) When an account is *vouched* in mozillians, the person is subscribed to the mailing list - Sign up with a unique, never before used email address in ET, for mozillians.org - Vouch that individual (*individuals should not subscribed to the mailing list until they are vouched). - Check "Master_Subscribers" data extension to make sure that that email address has MOZILLA_PHONE_FLG = Y 2) When a person updates their profile, their phonebook data in exact target is updated (including group memberships) * Check "PHONEBOOK" data extension to see that the fields were updated. Use the "Check an email address" query and change "Master_Subscribers" to "PHONEBOOK" 3) Deleting your profile unsubscribes you - Check "Master_Subscribers" data extension to make sure that that email address has MOZILLA_PHONE_FLG = N Rebecca knows how to query for an email address in the different data extensions by using the "Check an email address" query function.
Commits pushed to master at https://github.com/mozilla/mozillians https://github.com/mozilla/mozillians/commit/cd40c74c2a3d7c4ab8923c931687963f0fe360be Bug 920270 - Basket subscribe API not returning token anymore The Basket API's subscribe call is going to stop returning the token and become purely asynchronous. Don't expect the token in the response, and adapt other code to query Basket for the token later if we need it. https://github.com/mozilla/mozillians/commit/9dcee12e4eaad8b9c42008db111d396be0213f82 Merge pull request #706 from dpoirier/bug-920270-basket-api Bug 920270 - Basket subscribe API not returning token anymore
Need to wait for latest basket to be deployed (bug 944055)
Depends on: 944055
No longer depends on: 902026
Did you notice that the bug you just referenced is resolved - fixed? Latest basket is in prod. Feel free to proceed.
Yes, thanks pmac.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Verified step 1 & 3 from Comment 11. Unable to verify step 2. The fields in check Indiv Email in Phonebook do not correspond to the regular Indiv Email fields. The phonebook fields do not match what is editable in the Mozillians profile, and the modified date does not update [it always matches create date].
dpoirier, can you reach out to :rbillings and walk her through the steps to validate? And could you update this bug with any modification to the steps in comment 11 or with any other information that might help someone understand/test this in the future?
Flags: needinfo?(dpoirier)
I don't know what's /supposed/ to be in the phonebook data extension in Exact Target. I can only look at the code and say what it's putting there. If 'phonebook' is the Exact Target record in the phonebook data extension, and 'profile' is the Mozillians user profile, here's what the code is setting: - phonebook['token'] = token from basket - phonebook['country'] = profile['country'] - phonebook['city'] = profile['city'] - phonebook[name of each functional area] = 'Y' if user belongs to functional area, else 'N' and that's it. Any other fields in Exact Target might be getting updated automatically by Exact Target or something, but Mozillians code is not setting them explicitly. Justin or William, do you have any more information about what's /supposed/ to be in Exact Target?
Flags: needinfo?(dpoirier) → needinfo?(hoosteeno)
I have no information about it at all. Jess, William?
Flags: needinfo?(hoosteeno) → needinfo?(jdavis)
The only information I have are the fields in the "PHONEBOOK" data extension: EMAIL_ADDRESS COUNTRY CITY SYSTEMS_ADMINISTRATION BOOT2GECKO LOCALIZATION QUALITY_ASSURANCE CREATIVE METRICS MARKETING POLICY WEB_DEVELOPMENT CODING SUPPORT UX COMMUNICATIONS PROGRAM_MANAGEMENT LABS WEBFWD SECURITY DEVELOPER_DOCUMENTATION DEVELOPER_TOOLS MOBILE THUNDERBIRD APPS EVANGELISM GRAPHICS LEGAL ADD-ONS AUTOMATION RECRUITING PERSONA BUSINESS_DEVELOPMENT PEOPLE ACCESSIBILITY FUNDRAISING TOKEN MOZILLA_PHONE_FLG MOZILLA_PHONE_DATE EMAIL_FORMAT
Flags: needinfo?(jdavis)
Verified step 2 with help from Jess. All good.
Status: RESOLVED → VERIFIED
Flags: needinfo?(williamr)
You need to log in before you can comment on or make changes to this bug.