The default bug view has changed. See this FAQ.

Remove useless --enable-privilege option from remotereftest.py

RESOLVED FIXED

Status

Release Engineering
General Automation
P2
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: emk, Assigned: coop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
can you please add a description to this bug?
(Reporter)

Comment 2

4 years ago
The --enable-privilege functionality was removed by bug 913510. Now the option is present only to satisfy Android build slaves. We should remove the vestige.

Updated

4 years ago
Blocks: 920627

Updated

4 years ago
No longer blocks: 920627
QA Contact: john+bugzilla
(Assignee)

Comment 3

3 years ago
Created attachment 8442886 [details] [diff] [review]
Remove --enable-privilege
Attachment #8442886 - Flags: review?(gbrown)
Comment on attachment 8442886 [details] [diff] [review]
Remove --enable-privilege

Review of attachment 8442886 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

There are other places where we pass --enable-privilege, like http://mxr.mozilla.org/mozilla-central/source/testing/config/mozharness/android_panda_config.py#30 ... maybe we can remove those too, in another patch.
Attachment #8442886 - Flags: review?(gbrown) → review+
(Assignee)

Updated

3 years ago
Component: Other → General Automation
QA Contact: catlee
(Assignee)

Comment 5

3 years ago
Comment on attachment 8442886 [details] [diff] [review]
Remove --enable-privilege

Review of attachment 8442886 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/buildbotcustom/rev/09da67bef522
Attachment #8442886 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Assignee: nobody → coop
Status: NEW → ASSIGNED
Priority: -- → P2
(Assignee)

Comment 6

3 years ago
Created attachment 8443146 [details] [diff] [review]
Remove --enable-privilege (m-c patch)

Geoff: any chance this patch could land with DONTBUILD, assuming it passes review?
Attachment #8443146 - Flags: review?(gbrown)
Comment on attachment 8443146 [details] [diff] [review]
Remove --enable-privilege (m-c patch)

It seems safe, but it has the potential to bust tests -- I would not use DONTBUILD.
Attachment #8443146 - Flags: review?(gbrown) → review+
(Assignee)

Comment 8

3 years ago
Comment on attachment 8443146 [details] [diff] [review]
Remove --enable-privilege (m-c patch)

Review of attachment 8443146 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e7d54be8cb1
Attachment #8443146 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/8e7d54be8cb1
(Reporter)

Updated

3 years ago
Depends on: 1028438
You need to log in before you can comment on or make changes to this bug.