B2G RIL: Buf.read/writeUint32 should be of signed int32 operation.

RESOLVED FIXED

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: allstars.chh, Assigned: allstars.chh)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The returned value from Buf.readUint32 should be signed,

Per ECMA-262 Edition 5, clause 11.7.1 The Left Shift operator , point 8
The result is a signed 32-bit integer.

So we should rename readUint32 to readInt32, same for write and readUint32List.
Summary: B2G RIL: Buf.read/writeUint32 should be signed int32 operation. → B2G RIL: Buf.read/writeUint32 should be of signed int32 operation.
Assignee: nobody → allstars.chh
Posted patch Patch (obsolete) — Splinter Review
Just had a quick scan, wow!  Will feedback later.
Attachment #810337 - Flags: review?(vyang) → review+
Posted patch PatchSplinter Review
covert to hg format.
Attachment #810337 - Attachment is obsolete: true
Attachment #810410 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/d364406e42ee
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.