The returned value from Buf.readUint32 should be signed, Per ECMA-262 Edition 5, clause 11.7.1 The Left Shift operator , point 8 The result is a signed 32-bit integer. So we should rename readUint32 to readInt32, same for write and readUint32List.
Summary: B2G RIL: Buf.read/writeUint32 should be signed int32 operation. → B2G RIL: Buf.read/writeUint32 should be of signed int32 operation.
Assignee: nobody → allstars.chh
Attachment #810337 - Flags: review?(vyang)
Just had a quick scan, wow! Will feedback later.
Attachment #810337 - Flags: review?(vyang) → review+
covert to hg format.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.