920391 - B2G RIL: Buf.read/writeUint32 should be of signed int32 operation.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

The returned value from Buf.readUint32 should be signed,

Per ECMA-262 Edition 5, clause 11.7.1 The Left Shift operator , point 8
The result is a signed 32-bit integer.

So we should rename readUint32 to readInt32, same for write and readUint32List.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Just had a quick scan, wow!  Will feedback later.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

covert to hg format.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://tbpl.mozilla.org/?tree=Try&rev=5fa3ef584eb5

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d364406e42ee

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d364406e42ee