Closed
Bug 920394
Opened 11 years ago
Closed 11 years ago
[Keyboard] Build time default keyboard should use |utils.gaiaOriginURL| to generate app origin
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 913782
People
(Reporter: GaryChen, Assigned: GaryChen)
References
Details
Attachments
(1 file)
Build in apps have different domain, protocol and port in devices and Browser, for example: In keyboard apps: Devices: app://keyboard.gaiamobile.org Browser: http://keyboard.gaiamobile.org:8000 bug 913782 use hard code (app://keyboard.gaiamobile.org) for keyboard layouts in build/settings.js., so it make keyboard framework failed in FF nightly. So build time default keyboard should use |utils.gaiaOriginURL| to generate app origin
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → koi?
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gchen
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #809692 -
Flags: review?(yurenju.mozilla)
Comment 2•11 years ago
|
||
Comment on attachment 809692 [details]
pr.html
looks good, r=yurenju. please land this commit if you get green state on travis-ci.
Attachment #809692 -
Flags: review?(yurenju.mozilla) → review+
Comment 4•11 years ago
|
||
travis turns green.
Assignee | ||
Comment 5•11 years ago
|
||
Thanks, landed in gaia master https://github.com/mozilla-b2g/gaia/commit/4bbd1850a60925fc6ae7aa7a14b9b634a8187607 https://github.com/mozilla-b2g/gaia/commit/1e5fdc24c0df8db617b2d5bc6d84d0b3ae11238b
blocking-b2g: koi+ → koi?
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 6•11 years ago
|
||
Note - in the future, if there's smoketest bustage, you need to backout, instead of doing a forward fix. This might be what caused bug 920588.
Comment 7•11 years ago
|
||
Talked to Gary. he'll backout the changes in this bug and also bug 913782. it should fix the regression for bug 920588.
Assignee | ||
Comment 8•11 years ago
|
||
travis log https://travis-ci.org/mozilla-b2g/gaia/builds/11766197
Comment 9•11 years ago
|
||
Backed out with bug 913782. I'll set this as a dupe of that, and let's work together to get bug 913782 fixed properly. :)
Resolution: FIXED → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•