920422 - [Dialer] The flow is not correct when a call is ongoing and user tries to add another participant

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[isabelrios]

Attachment: 2013-09-25-09-54-10.png

09/24 v1.2 build:
Gecko-85ead36
Gaia-a22ba4a

STR
1. Open dialer and make a call
2. Once the call is stablished, tap on the '+' icon to add a participant

EXPECTED
The screen is shown fine.
Copying Victoria who could help to show the correct screen to be shown.

ACTUAL
Please see screenshot attached.

Comment 1

[Etienne Segonzac (:etienne)]

Again, needinfoing Victoria to get actionable input.

Comment 2

[Victoria Gerchinhoren [:vicky]]

This is not a visual issue, it is a flow one. Please refer to the specs (https://mozilla.app.box.com/s/cpwxyeisjurklut93f0a) as when you tap on the "add participant" button it should take you to the contacts list and not the call log, so you can pick a contact or I guess use dialer to dial the number if it's not in your already saved contacts.

I have opened a new bug to follow up the layout implementation polishing for this component: https://bugzilla.mozilla.org/show_bug.cgi?id=921056

Thanks!

Comment 3

[isabelrios]

More info, the call log is open because it has been previously used. 
If dialer has not been open before nor the call log, the app is not in background then, when tapping on '+' when there is call ongoing, the dialer is shown. But it is shown with the first number dialed and with the status bar shown wrongly, please see screenshot attached.

Comment 4

[isabelrios]

Attachment: 2013-09-27-09-34-29.png

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

triage: koi+ for UI problems
maybe a dup of Bug 920298 and bug 918534

Comment 6

[isabelrios]

Changing the subject to clarify the issue to cover here.
The flow is not correct when adding a participant to a call. There are several scenarios which does not follow the specs https://mozilla.app.box.com/s/cpwxyeisjurklut93f0a, page 15.

Dialer is closed: when tapping on '+' when there is call ongoing, the dialer is shown. But it is shown with the first number dialed and with the status bar shown wrongly, please see screenshot attached.

Dialer has been open and is in background: when tapping on '+' the dialer is open in the state is had been open las time, it means, if call log was open, the it will be shown (attachment 2013 [details]-09-25-09-54-10.png).

When tapping on '+' what should be open is the contact list.

Comment 7

[Etienne Segonzac (:etienne)]

Thanks Isabel, crystal clear!

Comment 8

[Etienne Segonzac (:etienne)]

Attachment: Pointer to gaia PR

I tried really hard but couldn't find a way to test:
* posting messages on window.opener
* window.location.hash changes

And I don't want to make structural changes to these files to make them more testable in a koi+ patch.

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 813234 [details]
Pointer to gaia PR

Yabon.

Comment 10

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/47f50a6822bf2cd8635bc215e2fb09642d8eaf5c

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 47f50a6822bf2cd8635bc215e2fb09642d8eaf5c to:
v1.2: 4e46fe4312fd8c6686f811020e0b1cd4e14a4b46

Comment 12

[isabelrios]

I re-checked this bug and now the flow is as described.
User is taken to contacts list: 
According to the wfs: https://mozilla.app.box.com/s/cpwxyeisjurklut93f0a/1/1030018334/9944055924/1, pag 15/42. 

But, when there are no contact(s), should be shown the empty contact list screen?
I am attaching here the current view when there are not contact(s) in the address book. 
Cc and ni Ayman

Comment 13

[isabelrios]

Attachment: Empty contact list.png

Comment 14

[ayman maat :maat]

(In reply to Isabel Rios [:isabel_rios] from comment #12)
> I re-checked this bug and now the flow is as described.
> User is taken to contacts list: 
> According to the wfs:
> https://mozilla.app.box.com/s/cpwxyeisjurklut93f0a/1/1030018334/9944055924/1,
> pag 15/42. 
> 
> But, when there are no contact(s), should be shown the empty contact list
> screen?
> I am attaching here the current view when there are not contact(s) in the
> address book. 
> Cc and ni Ayman

I would suggest that if there are no contacts in the contact list that we take the user straight to the Dialler as it is pointless showing them an empty contact list in this instance.

ni? to Jacqueline who is underwriting the UX specs for Dialler to confirm this or to make a counter proposal.

Comment 15

[Etienne Segonzac (:etienne)]

(In reply to ayman maat :maat from comment #14)
> I would suggest that if there are no contacts in the contact list that we
> take the user straight to the Dialler as it is pointless showing them an
> empty contact list in this instance.

Makes sense to me, but this should probably be a follow-up non blocking bug because it won't be straightforward.

Comment 16

[Noemí Freire (:noemi)]

(In reply to Etienne Segonzac (:etienne) from comment #15)
> (In reply to ayman maat :maat from comment #14)
> > I would suggest that if there are no contacts in the contact list that we
> > take the user straight to the Dialler as it is pointless showing them an
> > empty contact list in this instance.
> 
> Makes sense to me, but this should probably be a follow-up non blocking bug
> because it won't be straightforward.

Hi,

A follow up bug has been created for covering "no contacts" scenario - bug 926825

Comment 17

[Jacqueline Savory [:jsavory] UX]

I agree with Ayman's proposal for the no contacts case, as it is essentially one less step for the user.

Comment 18

[isabelrios]

Checked this bug but did not verify it before, changing the status now after testing with v1.2 11/29 build:
Gecko-e537f6f
Gaia-075e60c