Closed
Bug 920524
Opened 11 years ago
Closed 11 years ago
[Clock] Timer sound selection does not preview sound
Categories
(Firefox OS Graveyard :: Gaia::Clock, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bmac, Assigned: bmac)
Details
Attachments
(1 file)
Steps to reproduce: 1) Open the clock app 2) Touch the timer button 3) Touch the button under the "Sound" label (this should open a select chooser) 4) Touch a new sound option Expected behavior: The new sound selected should be previewed while the select chooser is open (see the sound chooser on the alarm edit screen) Actual behavior: no sound is played
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → brendan
|
|
Assignee | |
Comment 1•11 years ago
|
||
I have a branch with a fix for this issue. https://github.com/bmac/gaia/tree/920524 I am waiting on https://bugzilla.mozilla.org/show_bug.cgi?id=917339 to land before submitting a pr for this issue because it takes advantage of some the refactorings made as a part of 917339.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #813510 -
Flags: review?(mike)
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
|
||
Comment 3•11 years ago
|
||
Comment on attachment 813510 [details] [review] Github pull request This looks great, Brendan! Sorry for the delay
Attachment #813510 -
Flags: review?(mike) → review+
|
|
||
Comment 4•11 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/ddf5801c5329059b3a899f953ada8a086574f925 Nice work!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•