920587 - [BB] Confirm with content BB should properly support the absence of a <small> element

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

The current version of the confirm with content BB (http://buildingfirefoxos.com/building-blocks/confirm.html) does not properly support the absence of the <small> element (confirmation subtitle). This BB should properly manage this case so that the <strong> element (confirmation title) is vertically aligned to the space reserved for the image in case no <small> element is provided.

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 811056 [details]
patch in github

Looking good to me :-) Using it right away in bug 916010 :-)

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: https://github.com/mozilla-b2g/gaia/commit/340d6feca6ac508a06b1e6054449b2e0394b1812

Thanks Germán!

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 811056 [details]
patch in github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Confirm BB does not properly manage the absence of subtitle
[User impact] if declined: Bad user experience (visualization)
[Testing completed]: Tested in device
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None

Comment 5

[Jason Smith [:jsmith]]

Not blocking - agreed we should fix and consider approving, but this isn't a blocker for release.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 340d6feca6ac508a06b1e6054449b2e0394b1812 to:
v1.2: 35f953fe049cfe718ed9e2d6d218f763f11794aa

Comment 7

[Masashi Honma]

This patch causes error message in "adb logcat".

This message is displayed on booting.

--------------------
E/GeckoConsole(  108): [JavaScript Warning: "Error in parsing value for 'flex'.  Declaration dropped." {file: "app://keyboard.gaiamobile.org/shared/style/confirm.css" line: 215 column: 8 source: "  flex: column wrap;"}]
--------------------

hardware: KEON
Gaia: 5311b40f07e18fb612ce80804ff16ab5010da54a
Gecko: 0121083133a412524450bf38e546ca2c03765490

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 340d6feca6ac508a06b1e6054449b2e0394b1812 to:
v1.3 already had this commit