Remove "bootstrap fixes" part of main.less

VERIFIED FIXED in 2013-09-26

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: julia, Assigned: julia)

Tracking

other
2013-09-26

Details

(Assignee)

Description

5 years ago
There are some unnecessary bootstrap styles implemented in the main.less stylesheet that are no longer needed. Bootstrap was removed, as of this bug fix: https://bugzilla.mozilla.org/show_bug.cgi?id=915569

Pages we'll need to take a close look at:

/about/
/invite/

Comment 1

5 years ago
Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/a6be4d4015ada2c10767517250a48f809590f1ac
[Fix Bug 920590] Removing bootstrap references from main.less stylesheet.

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
Julia can we verify that somehow or is it qa-?
Flags: needinfo?(julia)
(Assignee)

Comment 3

5 years ago
Hey Giorgos! 

Sorry for not being more explicit on what to look for. I think that the best way to verify that these removal of these styles are not breaking anything, is to test the /about/ page and make sure that it looks good (e.g. QA against what is currently on prod). This commit removes any styles that relate to the `.tabbable` class, as well as styling that was assigned specifically to the /about/ page, in relation to some bootstrap fixes.

Does that make sense? If not, please let me know if you need further clarification!
Flags: needinfo?(julia)
Thanks for QA steps Julia. 

Unfortunately /about doesn't appear correctly on stage. Re-opening :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Julia, can you r? this?

https://github.com/mozilla/mozillians/pull/644
Flags: needinfo?(julia)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Looks good on stage.
Status: RESOLVED → VERIFIED
Target Milestone: --- → 2013-09-26
Flags: needinfo?(julia)
You need to log in before you can comment on or make changes to this bug.