920590 - Remove "bootstrap fixes" part of main.less

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Julia Elman]

There are some unnecessary bootstrap styles implemented in the main.less stylesheet that are no longer needed. Bootstrap was removed, as of this bug fix: https://bugzilla.mozilla.org/show_bug.cgi?id=915569

Pages we'll need to take a close look at:

/about/
/invite/

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/a6be4d4015ada2c10767517250a48f809590f1ac
[Fix Bug 920590] Removing bootstrap references from main.less stylesheet.

Comment 2

[Giorgos Logiotatidis [:giorgos]]

Julia can we verify that somehow or is it qa-?

Comment 3

[Julia Elman]

Hey Giorgos! 

Sorry for not being more explicit on what to look for. I think that the best way to verify that these removal of these styles are not breaking anything, is to test the /about/ page and make sure that it looks good (e.g. QA against what is currently on prod). This commit removes any styles that relate to the `.tabbable` class, as well as styling that was assigned specifically to the /about/ page, in relation to some bootstrap fixes.

Does that make sense? If not, please let me know if you need further clarification!

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Thanks for QA steps Julia. 

Unfortunately /about doesn't appear correctly on stage. Re-opening :(

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

Julia, can you r? this?

https://github.com/mozilla/mozillians/pull/644

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/2b5879357447f73a4850fe59bd0a2e49ebd84186
[fix bug 920590] Float image on about page

https://github.com/mozilla/mozillians/commit/77a4467a5a36edb160dc87a4fb2be12487a6c127
Merge pull request #644 from hoosteeno/about_page

[fix bug 920590] Float image on about page

Comment 7

[Giorgos Logiotatidis [:giorgos]]

Looks good on stage.