920627 - Add symbols path for Android x86 reftests and xpcshell tests

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Geoff Brown [:gbrown]]

From https://tbpl.mozilla.org/php/getParsedLog.php?id=28353069&tree=Cedar&full=1#error0:

08:55:57     INFO - PROCESS-CRASH | http://10.0.2.2:8854/tests/content/canvas/test/reftest/webgl-color-test.html?aa&_____&_____&_______&preserve&_______ | application crashed [Unknown top frame]
08:55:57     INFO - Crash dump filename: /tmp/tmpECQ51l/2ec66ad3-cf36-f9f7-429631cf-7a4daca5.dmp
08:55:57     INFO - No symbols path given, can't process dump.

It looks like no symbols path is passed to remotereftest.py:

/builds/slave/talos-slave/test/build/venv/bin/python /builds/slave/talos-slave/test/build/tests/reftest/remotereftest.py --app=org.mozilla.fennec --ignore-window-size --bootstrap --enable-privilege --remote-webserver=10.0.2.2 --xre-path=/builds/slave/talos-slave/test/build/hostutils/xre --utility-path=/builds/slave/talos-slave/test/build/hostutils/bin --deviceIP=127.0.0.1 --devicePort=20701 --http-port=8854 --ssl-port=4454 --httpd-path reftest/components --total-chunks 10 --this-chunk 5 tests/layout/reftests/reftest.list

Comment 1

[Armen [:armenzg]]

Good catch!
This can be added to configs/android/androidx86.py 

Does xpcshell need it as well? I assume so.

Comment 2

[Geoff Brown [:gbrown]]

Yes, remotexpcshelltests.py also takes --symbols-path=...

Comment 3

[Armen [:armenzg]]

Attachment: androidx86.symbolspath.diff

I've re-triggered a couple of jobs on Ash to see if it works and/or breaks anything.

Comment 4

[Aki Sasaki (not active)]

Comment on attachment 810651 [details] [diff] [review]
androidx86.symbolspath.diff

I tend to leave trailing commas whenever I can (i.e. not in json) so adding items is easier.  Might be a style thing.

Comment 5

[Armen [:armenzg]]

Comment on attachment 810651 [details] [diff] [review]
androidx86.symbolspath.diff

checked-in with trailing commas.
https://hg.mozilla.org/build/mozharness/rev/719998370072

Comment 6

[Armen [:armenzg]]

I landed it to production.