MachCommandBase doesn't use the robust MozbuildObject.from_environment() code path for determining the object directory path. We should probably have it do that.
Created attachment 812047 [details] [diff] [review] Improve build environment detection in mach I /think/ this will do it. There is a risk the tests will fail because environment tests on buildbot have issues for some unknown reason. https://tbpl.mozilla.org/?tree=Try&rev=b324466e542d
Attachment #812047 - Flags: review?(mh+mozilla)
Comment on attachment 812047 [details] [diff] [review] Improve build environment detection in mach bz, vlad: I believe you have both complained about mach not properly detecting build environments before. I'm optimistic this patch fixes it. If it doesn't, please paste the output of |mach environment| with and without this patch. Please also point out what's wrong.
Comment on attachment 812047 [details] [diff] [review] Improve build environment detection in mach I don't think I've used mach enough to run into this sort of problem with it yet, actually. Only with make and running virtualenv python directly....
Attachment #812047 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd6ed8459a47 With disabled test because of buildbot issues. I really need to get bug 853954 sorted out.
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
This does fix things for a manually configured objdir. That's probably enough. It doesn't work for a bare newly created objdir: % mkdir foo % cd foo % ../mozilla-central/mach build Could not run mach: No mach source directory found. This is way better than before, and is probably OK given my objdir-out-of-srcdir usage.. before it would happily create an objdir in the srcdir and start building there.
You need to log in before you can comment on or make changes to this bug.