MachCommandBase always detects objdir from mozconfig path

RESOLVED FIXED in mozilla27

Status

Firefox Build System
General
RESOLVED FIXED
5 years ago
2 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

(Blocks: 1 bug)

Trunk
mozilla27
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
MachCommandBase doesn't use the robust MozbuildObject.from_environment() code path for determining the object directory path. We should probably have it do that.
(Assignee)

Comment 1

5 years ago
Created attachment 812047 [details] [diff] [review]
Improve build environment detection in mach

I /think/ this will do it. There is a risk the tests will fail because
environment tests on buildbot have issues for some unknown reason.

https://tbpl.mozilla.org/?tree=Try&rev=b324466e542d
Attachment #812047 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Assignee: nobody → gps
(Assignee)

Comment 2

5 years ago
Comment on attachment 812047 [details] [diff] [review]
Improve build environment detection in mach

bz, vlad: I believe you have both complained about mach not properly detecting build environments before. I'm optimistic this patch fixes it.

If it doesn't, please paste the output of |mach environment| with and without this patch. Please also point out what's wrong.
Attachment #812047 - Flags: feedback?(vladimir)
Attachment #812047 - Flags: feedback?(bzbarsky)
Comment on attachment 812047 [details] [diff] [review]
Improve build environment detection in mach

I don't think I've used mach enough to run into this sort of problem with it yet, actually.  Only with make and running virtualenv python directly....
Attachment #812047 - Flags: feedback?(bzbarsky)
Attachment #812047 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd6ed8459a47

With disabled test because of buildbot issues. I really need to get bug 853954 sorted out.
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/fd6ed8459a47
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Blocks: 924472
(Assignee)

Updated

5 years ago
Blocks: 923573
This does fix things for a manually configured objdir.  That's probably enough.  It doesn't work for a bare newly created objdir:

% mkdir foo
% cd foo
% ../mozilla-central/mach build
Could not run mach: No mach source directory found.

This is way better than before, and is probably OK given my objdir-out-of-srcdir usage.. before it would happily create an objdir in the srcdir and start building there.
(Assignee)

Updated

4 years ago
Attachment #812047 - Flags: feedback?(vladimir)

Updated

2 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.