920702 - Download button does not respond while pdf is loading

Status: REOPENED

(Firefox :: PDF Viewer, defect, P3)

Description

[aleth [:aleth]]

STR: Open a large pdf file that takes some time to display the first page (i.e. which displays a progress bar while loading). Click on the pdf.js download button.

Expected behaviour: Download dialog should pop up immediately.

Actual behaviour: Button is not responsive until the progress bar is at 100%.

This makes it difficult to open a pdf file in an external viewer instead of pdf.js precisely in those instances where pdf.js is a bit slow.

Comment 1

[Marco Castelluccio [:marco]]

Easily reproducible with http://scholar.princeton.edu/sites/default/files/oversize_pdf_test_0.pdf.

Comment 2

[Marco Castelluccio [:marco]]

After fixing this, we should test the scenarios in bug 1755509 comment 6.

Comment 3

[Kenan]

This bug was fixed by:
2022-09-07T23:50:19.091000: DEBUG : Found commit message:
Bug 1757771, always launch the save dialog when pressing the PDF Viewer download button, and remove test code that expected the unknown type dialog to appear, r=marco

Differential Revision: https://phabricator.services.mozilla.com/D145814

2022-09-07T23:50:19.091000: DEBUG : Did not find a branch, checking all integration branches
2022-09-07T23:50:19.093000: INFO : The bisection is done.

Comment 5

[Calixte Denizet (:calixte)]

I can reproduce the issue with nightly on Windows 11.