Open Bug 920706 Opened 6 years ago Updated 6 years ago
In crashtest runs, the Special
Powers addon isn't installed if you use a custom filename for your manifest
I frequently do targeted crashtest runs by doing e.g. cp ./path/to/crashtest.list ./path/to/mine.list [edit ./path/to/mine.list to inlcude only a few tests] ./mach crashtest ./path/to/mine.list However, this got me into trouble when testing martijn's patch in bug 917061 comment 27 -- SpecialPowers wasn't being defined, for some reason. Turns out that happens because we only hook up SpecialPowers if you're using the right manifest name, as shown here: > 88 # I would prefer to use "--install-extension reftest/specialpowers", but that requires tight coordination with > 89 # release engineering and landing on multiple branches at once. > 90 if special_powers and (manifest.endswith('crashtests.list') or manifest.endswith('jstests.list')): > 91 addons.append(os.path.join(SCRIPT_DIRECTORY, 'specialpowers')) http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/runreftest.py#88 I'm pretty sure this is the only place we have a hardcoded dependency on what your manifest name is. It'd be great to remove that hardcoded dependency.
Summary: Don't make SpecialPowers registration depend on manifest file-name → In crashtest runs, the SpecialPowers addon isn't installed if you use a custom filename for your manifest
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.