B2G desktop mochitests broken from bug 746243

RESOLVED FIXED in mozilla27

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla27
All
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bug 746243 removes automation.py from desktop mochitests, but this breaks the b2g desktop mochitests which still depend on it. I noticed this while I was in the process of getting them running in automation so this doesn't happen in the future :)

Patch coming shortly.
(Assignee)

Updated

5 years ago
Blocks: 916119
(Assignee)

Comment 1

5 years ago
Created attachment 810145 [details] [diff] [review]
Patch 1.0 - fix bustage

This gets things working again.

The only comment I have is using "appname" to figure out which Runner class to use. In b2g the preferred method of detection is "toolkit" == "gonk" to account for b2g desktop or other branding. But b2g mochitests don't use this function at all so for now I think this patch is good enough.
Attachment #810145 - Flags: review?(jhammel)

Comment 2

5 years ago
Comment on attachment 810145 [details] [diff] [review]
Patch 1.0 - fix bustage

Review of attachment 810145 [details] [diff] [review]:
-----------------------------------------------------------------

if it passes locally, lgtm
Attachment #810145 - Flags: review?(jhammel) → review+
https://hg.mozilla.org/mozilla-central/rev/03ee2343b34e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.