Closed Bug 920718 Opened 6 years ago Closed 6 years ago

B2G desktop mochitests broken from bug 746243

Categories

(Testing :: Mochitest, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

Bug 746243 removes automation.py from desktop mochitests, but this breaks the b2g desktop mochitests which still depend on it. I noticed this while I was in the process of getting them running in automation so this doesn't happen in the future :)

Patch coming shortly.
Blocks: 916119
This gets things working again.

The only comment I have is using "appname" to figure out which Runner class to use. In b2g the preferred method of detection is "toolkit" == "gonk" to account for b2g desktop or other branding. But b2g mochitests don't use this function at all so for now I think this patch is good enough.
Attachment #810145 - Flags: review?(jhammel)
Comment on attachment 810145 [details] [diff] [review]
Patch 1.0 - fix bustage

Review of attachment 810145 [details] [diff] [review]:
-----------------------------------------------------------------

if it passes locally, lgtm
Attachment #810145 - Flags: review?(jhammel) → review+
https://hg.mozilla.org/mozilla-central/rev/03ee2343b34e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.