Closed
Bug 920730
Opened 12 years ago
Closed 12 years ago
.deps file for WebIDL bindings are randomly ordered
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Bug 904743 did this:
- f.write("\n".join(outputprefix + ": " + os.path.join(srcprefix, x) for
- x in sorted(root.deps())))
+ rule.add_dependencies(os.path.join(srcprefix, x) for x in root.deps())
because the dumping stuff in "rule" sorted things.
Then bug 912914 removed that sorting. But root.deps() is a set(), so now we get random order.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #810104 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [need review]
|
||
Comment 2•12 years ago
|
||
Comment on attachment 810104 [details] [diff] [review]
Output the WebIDL .deps files in a consistent order.
Review of attachment 810104 [details] [diff] [review]:
-----------------------------------------------------------------
sorry :(
Attachment #810104 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
It's not a big deal. Thank you for the review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/225f540cd413
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla27
|
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•