Sidebars should have a more explicit error message for remote uris

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evold, Assigned: evold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

At the moment invalid uris and "valid" remote uris have the same error message, in the latter case the message should be more explicit about the problem.
Created attachment 810218 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1249

Pointer to Github pull-request
Attachment #810218 - Flags: review?(zer0)
Attachment #810218 - Flags: feedback?(wbamberg)
Assignee: nobody → evold
Comment on attachment 810218 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1249

Thanks Erik!
Attachment #810218 - Flags: feedback?(wbamberg) → feedback+

Updated

5 years ago
Priority: -- → P2
r+ with the "non-remote URI" replaced by "local URI".
Attachment #810218 - Flags: review?(zer0) → review+

Comment 4

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/7dd8a9dc345cde53ebc5d8bc24a21e3dd7fa5e46
Bug 920812 - Sidebars should have a more explicit error message for remote uris

https://github.com/mozilla/addon-sdk/commit/290408ff92870c91be768a888c423a556bf819ce
Merge pull request #1249 from erikvold/920812

Bug 920812 - Sidebars should have a more explicit error message for remote uris r=@zer0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.