Closed
Bug 920833
Opened 11 years ago
Closed 11 years ago
update sqlite3 to v2.1.17 in all tools, because this version no longer needs c++ compiling
Categories
(Webmaker Graveyard :: Webmaker-suite, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: michiel)
References
Details
Attachments
(1 file)
sqlite3 at version 2.1.7 as we use in our tools is proving a major stumbling block for contributors. The latest version no longer requires compiling, hosting precompiled binaries on AWS for the various platforms (hurray!) and it will be much fewer headaches and c++ stack installations (no xcode! no MSVC++!) if we update all our tools to 2.1.17. This bug has been filed as tracking bug for the other components.
Comment 2•11 years ago
|
||
This can be be close now I guess, but will let the Master do it :P
it needs a version forward for webmaker-suite too, because this changes the instructions for installation, too =D
As it turns out, on a completely clean Win32 install 2.1.17 still has an issue with a "module.js" file, which fails the precompiled validation. https://github.com/developmentseed/node-sqlite3/issues/198 has been filed, if this gets fixed we can finish up this ticket, probably with another version-forward for sqlite3...
the solution is that any windows that sqlite3 needs to be installed on has to have the vc++ redistributatble package installed, which means any windows machine that is actually being used for programs and/or games will typically already have that be the case. I will still add this information to the README for windows users, but it's not a more-often-than-not optional step. Great win!
hotfix for thimble, which somehow lost the correct emulated check
Attachment #811352 -
Flags: review?(scott)
Comment 7•11 years ago
|
||
Comment on attachment 811352 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/234 Thanks, fixed!
Attachment #811352 -
Flags: review?(scott) → review+
all tools updated.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•