920839 - Value selectors is not screen reader friendly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Eitan Isaacson [:eeejay]]

There are some well-intentioned aria roles and states, but they don't do the trick well. The result is that the options are not selectable.

Comment 1

[Eitan Isaacson [:eeejay]]

This bug should apply to all value selectors, the simple one, the time selector, and the date selector.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13368

Pointer to Github pull-request

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 827122 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13368

Looks pretty good but I really don't know much about this piece of code so forwarding the review.

(Added a small comment on github)

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 827122 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13368

Please address the feedback etienne given.

Comment 5

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/7e8eeef74e25859a4fdf661845a45037e7245f2b

Comment 6

[Kevin Grandon :kgrandon]

We had to back this out due to a failing unit test. Backout commit: https://github.com/mozilla-b2g/gaia/commit/063e1e0ece967e0076966dba65418054d9ea7451

Failure details:

 [system] value selector/spin date picker "before each" hook:

TypeError: this.container is null

at initUI (http://system.gaiamobile.org:8080/js/value_selector/value_picker.js:110)

at init (http://system.gaiamobile.org:8080/js/value_selector/value_picker.js:100)

at VP (http://system.gaiamobile.org:8080/js/value_selector/value_picker.js:18)

at SpinDatePicker (http://system.gaiamobile.org:8080/js/value_selector/spin_date_picker.js:248)

at (anonymous) (http://system.gaiamobile.org:8080/test/unit/spin_date_picker_test.js:39)

at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)

at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)

at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)

at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)

at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Comment 7

[Kevin Grandon :kgrandon]

(Please ensure Travis is green before pressing the merge button.)

Comment 8

[Eitan Isaacson [:eeejay]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13537

Pointer to Github pull-request

Comment 9

[Eitan Isaacson [:eeejay]]

Comment on attachment 829623 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13537

Waiting for this to be green in Travis.

Comment 10

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/e2940660444cbedd63ca6ba7933bd1b4658504de

Updated unit test. Travis looks green and happy.