Closed Bug 920925 Opened 6 years ago Closed 6 years ago

[Contacts] Cannot recover when trying to add a contact only with carrier

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

VERIFIED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: isabelrios, Unassigned)

Details

(Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(2 files)

Attached image 2013-09-26-08-52-21.png
09/25 v1.2 build

STR
Create a contact only with carrier, tap on Done

EXPECTED
Carrier field should not be available until user introduces a phone number

ACTUAL
The device keeps trying to add the contact till closind the app
Please see screenshot attached.
Flags: needinfo?(aymanmaat)
Hmm I think that the add/edit contact form needs a good UX review and some corrective surgery as it has not changed since the design was ported over 1:1 from its originating app. Anyway…

As there is no reason to have a 'carrier' without a 'phone number', as a quick win, I would advise: 

1) to disable the carrier field until *something* (by this i mean a single character) has been input into the Phone Number field. 

2) if the user: 

 	a) first adds phone number
	b) then adds content to the now active 'carrier' field
	c) then deletes the phone number 

…in this scenario we should allow the carrier field to remain editable as it will still contain content that the user has input into it and it would be quite disorientating to make it inactive with the users input still visible and quite frustrating to automatically remove the content that the user has input into the carrier field because the content of the phone number field has been removed… after all the user might be trying to correct a mistake in the phone number not actually delete it. If the then user proceeds to submit the form whilst there is no content in the 'phone field' but content still in the 'carrier field' discard the content from the carrier field that is associated to the empty phone number field.
Flags: needinfo?(aymanmaat)
Attached file 12474.html
Resolved as per Ayman's spec.
Attachment #811099 - Flags: review?(francisco.jordano)
Comment on attachment 811099 [details]
12474.html

Working perfectly and unit tests passing \o/
Attachment #811099 - Flags: review?(francisco.jordano) → review+
Landed:

https://github.com/mozilla-b2g/gaia/commit/45168427618f0bcc909083fb9c6150d41f27e4a8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
Uplifted 45168427618f0bcc909083fb9c6150d41f27e4a8 to:
v1.2: f873d22469e736a0a444204573ab4e4eddc9974b
Verified on 10/09 v1.2 build:
Gecko-bd1bd24
Gaia-1499c58

Current behaviour as described in comment 1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.