920942 - window.confirm isn't shown

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Evyatar 'Tron' Amitay (everything.me)]

When on the homescreen, calling window.confirm (or just 'confirm') doesn't show the UI, but returns false immediately.

I checked this:
console.log('Before confirm');
var ret = confirm('Test confirm'); // nothing is shown
console.log('After confirm: ' + ret); // ret is 'false'

confirm is used by e.me when asking a user to save an app to their homescreen.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Does delete image in gallery app work for you? It's using confirm also.

Comment 2

[Cristian Rodriguez (:crdlc)]

jajaj yep, confirm is working there!

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

Yes, that works. I also checked from a browser and it works, but on the homescreen itself is doesn't work.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

UITest->Alert/Confirm->Confirm WFM.

I need to know what's the UI step to trigger 
https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/Brain.js#L688
to see what happens.

Comment 5

[Cristian Rodriguez (:crdlc)]

Search something on search bar and press and hold any icon displayed as result, right Evyatar?

Comment 6

[Cristian Rodriguez (:crdlc)]

The parameter is ok as well "Add Real Madrid C.F Official to Home Screen?" in my example but the confirm is not displayed

Comment 7

[Cristian Rodriguez (:crdlc)]

Could be something related to z-index?

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Cristian, it's not a style bug because a "false" value returns from it immediately without waiting for user input.

Comment 9

[Evyatar 'Tron' Amitay (everything.me)]

Yes, STR on comment 5 are correct.

Comment 10

[Cristian Rodriguez (:crdlc)]

This is true ;)

(In reply to Ran Ben Aharon (Everything.me) from comment #8)
> Cristian, it's not a style bug because a "false" value returns from it
> immediately without waiting for user input.

Comment 11

[Cristian Rodriguez (:crdlc)]

I was adding some log to ModalDialog and I can see that the frameType is undefined

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/modal_dialog.js#L87

Am I ok?

Comment 12

[Cristian Rodriguez (:crdlc)]

This is only a workaround to continue working on bug 910351

diff --git a/apps/system/js/homescreen_window.js b/apps/system/js/homescreen_window.js
index f03b025..eb615c6 100644
--- a/apps/system/js/homescreen_window.js
+++ b/apps/system/js/homescreen_window.js
@@ -35,6 +35,8 @@
     // into appWindow.
     this.frame = this.element;
     this.iframe = this.browser.element;
+    this.iframe.dataset.frameType = 'window';
+    this.iframe.dataset.frameOrigin = 'homescreen';
 
     this.element.appendChild(this.browser.element);

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Yes, please send me a pull request. Thanks!

Comment 14

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 810992 [details]
Patch v1

Ya, This reminds me I need to remove all dataset check later.. thanks!

Comment 16

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/2943da59b9cf96a55b607ee4dfb626ba6f89ae51

Comment 17

[Evyatar 'Tron' Amitay (everything.me)]

this works now, however there is an issue:

STR:
1. Search on e.me
2. Tap and Hold an app // "Add to Home Screen" confirm should show
3. Release the finger

Result:
The app is still clicked.
It looks as though the "touchend" event is still being sent to the app's icon.

Expected:
The app shouldn't get clicked.
The "touchend" event shouldn't be sent to the original element, since there's now an element overlaying everything.

Comment 18

[Cristian Rodriguez (:crdlc)]

fill other bug with it in system component

Comment 19

[Evyatar 'Tron' Amitay (everything.me)]

you're right, it's not relevant to this! done - bug 921397.