921046 - Implement a small retry loop for profile locking on startup

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Benjamin Smedberg]

Currently we try to lock the profile once and give up if we can't. If we're currently shutting down Firefox it would be nice to just retry a few times before giving up: maybe every .2 seconds for up to 10 seconds?

Comment 1

[Benjamin Smedberg]

Attachment: Implement a retry loop when locking the profile on startup, so that if a previous instance is shutting down, we will just start with a slight delay

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 814468 [details] [diff] [review]
Implement a retry loop when locking the profile on startup, so that if a previous instance is shutting down, we will just start with a slight delay

Review of attachment 814468 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: toolkit/components/startup/StartupTimeline.h
@@ +6,5 @@
>  mozilla_StartupTimeline_Event(PROCESS_CREATION, "process")
>  mozilla_StartupTimeline_Event(START, "start")
>  mozilla_StartupTimeline_Event(MAIN, "main")
> +mozilla_StartupTimeline_Event(SELECTPROFILE, "selectProfile")
> +mozilla_StartupTimeline_Event(AFTER_PROFILELOCKED, "afterProfileLocked")

Uber-nit: These should probably be SELECT_PROFILE and AFTER_PROFILE_LOCKED for the enum names.

Comment 3

[Benjamin Smedberg]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a80cca1ae52

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3a80cca1ae52