Closed Bug 921046 Opened 7 years ago Closed 7 years ago

Implement a small retry loop for profile locking on startup

Categories

(Toolkit :: Startup and Profile System, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: benjamin, Assigned: benjamin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently we try to lock the profile once and give up if we can't. If we're currently shutting down Firefox it would be nice to just retry a few times before giving up: maybe every .2 seconds for up to 10 seconds?
Attachment #814468 - Flags: review?(dtownsend+bugmail) → review+
Comment on attachment 814468 [details] [diff] [review]
Implement a retry loop when locking the profile on startup, so that if a previous instance is shutting down, we will just start with a slight delay

Review of attachment 814468 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: toolkit/components/startup/StartupTimeline.h
@@ +6,5 @@
>  mozilla_StartupTimeline_Event(PROCESS_CREATION, "process")
>  mozilla_StartupTimeline_Event(START, "start")
>  mozilla_StartupTimeline_Event(MAIN, "main")
> +mozilla_StartupTimeline_Event(SELECTPROFILE, "selectProfile")
> +mozilla_StartupTimeline_Event(AFTER_PROFILELOCKED, "afterProfileLocked")

Uber-nit: These should probably be SELECT_PROFILE and AFTER_PROFILE_LOCKED for the enum names.
Attachment #814468 - Flags: review?(nfroyd) → review+
You need to log in before you can comment on or make changes to this bug.