921095 - --disable-webgl should not build Angle code

Status: RESOLVED INVALID

(Core :: Graphics: CanvasWebGL, defect)

Description

[xunxun]

Attachment: disable-webgl.patch

When using --disable-webgl, we also build and link angle code. We should get rid of them.

The patch can solve it.

Comment 1

[Drew Willcoxon :adw]

Comment on attachment 810655 [details] [diff] [review]
disable-webgl.patch

Thanks for the patch.

Benoit, would you mind reviewing or finding someone appropriate?

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

I don't want to take this.  We need to be moving towards nuking --disable-webgl, not add more build system goop for it.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

I don't have a strong opinion either way, but there is a significant user base for the --disable-foo options:

 - people (like Bas) who configure with a lot of --disable-foo to get faster compiles. If that makes them more productive, then why not?

 - we still support Thunderbird and Seamonkey, and they build with --disable-webgl, so certainly they'll want to avoid building and packaging ANGLE + DX SDK DLLs.

This patch also isn't big at all.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 810655 [details] [diff] [review]
disable-webgl.patch

Review of attachment 810655 [details] [diff] [review]:
-----------------------------------------------------------------

R+ as in "this patch looks good by itself", but please do not land until we have reached consensus on whether we want to take it.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Jeff, do you have an opinion either way?

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

The amount of compile time savings is trivial, I don't really buy that argument.

For Thunderbird and Seamonkey -- WebGL is part of the web.  Gecko is a web renderer.  Seamonkey at least should want it for the browser piece; if either of them really doesn't want ANGLE, they can just not package the ANGLE DLLs.

Comment 7

[xunxun]

My patch's purpose is not to make build faster, and only to if we use --disable-webgl, gkmedias also contains Angle code, which is not reasonable. We should make gkmedias exclude angle code (make it smaller) when using --disable-webgl.

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

Filed bug 921747 for the separate, interesting question of whether we should drop the --disable-webgl option.

Until that is decided, for now, we do have a --disable-webgl option, and the present patch is a simple reasonable fix to it, so let's take it. But that doesn't imply that we'll continue supporting --disable-webgl in the future.

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

(This patch can land now).

Comment 10

[Benoit Jacob [:bjacob] (mostly away)]

Also, I was probably wrong about Seamonkey. Let's do as if I had only said "Thunderbird".

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This can't land yet, it needs review from a build peer.

Comment 12

[Guilherme Lima]

Invalid? (Bug 1052518)