Closed Bug 921115 Opened 9 years ago Closed 9 years ago
[Clock] Lap string is not localized
Steps to reproduce: 1. Change the system language in the Settings application to a value other than "English" 2. Open the Clock application 3. Navigate to the "Stopwatch" panel 4. Start the stopwatch 5. Press the "Lap" button Expected result: A new entry is added to the list of laps describing the lap in the selected language. Actual result: A new entry is added to the list of laps describing the lap in English.
Requesting "koi+" because the application cannot be fully localized in its present state.
blocking-b2g: --- → koi?
- stopwatch_panel.js - Use navigator.mozL10n.localize to localize the 'Lap [n]' label - Had to add an id to the element that is set via a template to be able to use it in the localize method - stopwatch_panel_test.js - I think a stopwatch_panel_test.js is already in another PR (https://github.com/mozilla-b2g/gaia/pull/12454), so this one is submitted here purely for review
Comment on attachment 812633 [details] [review] https://github.com/mozilla-b2g/gaia/pull/12579 Removed the lap-number #id for a simpler approach
Comment on attachment 812633 [details] [review] https://github.com/mozilla-b2g/gaia/pull/12579 Cancelling until the newly rebased version of this patch shows up on GitHub
Comment on attachment 812633 [details] [review] https://github.com/mozilla-b2g/gaia/pull/12579 Reopening for review after re-basing with master: - stopwatch_panel.js - Use navigator.mozL10n.localize to localize the 'Lap [n]' label - stopwatch_panel_test.js - Test localization in general with 'Lap localization' test - Change previous direct tests for 'Lap 1' string, etc., with tests against calls to localize instead
Comment on attachment 812633 [details] [review] https://github.com/mozilla-b2g/gaia/pull/12579 I've requested two minor changes on the pull request on GitHub. Other than that, this looks good! I'm happy with how precise the changes are, and I appreciate you being so proactive with rebasing over Yannick's recent commit :)
Comment on attachment 812633 [details] [review] https://github.com/mozilla-b2g/gaia/pull/12579 Resubmitting for review!
Comment on attachment 812633 [details] [review] https://github.com/mozilla-b2g/gaia/pull/12579 Looks good! I'll merge this in just a moment
Attachment #812633 - Flags: review?(mike) → review+
master: https://github.com/mozilla-b2g/gaia/commit/8c1a5f2205445bcb51bcc8406b38bf7b6b0cee43 Thanks, Evelyn
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
triage: fix to enable localization of a prominent new feature for Clock in 1.2, feels like we need to block on this one.
blocking-b2g: koi? → koi+
Attachment mime type: text/plain → text/x-github-pull-request
Uplifted 8c1a5f2205445bcb51bcc8406b38bf7b6b0cee43 to: v1.2: 3de512631816c14e88c9649ed35545fceac1fcab
Thanks! Verified it. * Test Build: - Gaia: 2ef9bc3c7a6de228b63e6ba3613eb0c0dd639c59 - Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/4a94d2ea9d37 - BuildID 20131028004002 - Version 26.0a2 Attaching the screenshot.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.