profile.sh won't capture if the main process isn't being profiled

RESOLVED FIXED in 1.3 C2/1.4 S2(17jan)

Status

Firefox OS
General
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: jld, Assigned: jld)

Tracking

unspecified
1.3 C2/1.4 S2(17jan)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There's an extra test for whether the main process has profiling enabled; this is after it has alreayd gathered the list of profiled processes and found it to be nonempty.  So if you're trying to profile just an app (and not also, e.g., the Compositor thread), you're confusingly told that the profiler isn't running when it is.
(Assignee)

Comment 1

4 years ago
Created attachment 8360759 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/314
Assignee: nobody → jld
Status: NEW → ASSIGNED
Attachment #8360759 - Flags: review?(bgirard)
(Assignee)

Comment 2

4 years ago
Comment on attachment 8360759 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/314

On second thought, don't review this just yet.  I think I can make this patch simpler.
Attachment #8360759 - Flags: review?(bgirard)
(Assignee)

Comment 3

4 years ago
Comment on attachment 8360759 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/314

Indeed, this is simpler than I originally thought.  Verified that simply deleting the test in cmd_capture allows capturing when a non-main process is being profiled, but still fails correctly when no process are profiled.
Attachment #8360759 - Flags: review?(bgirard)
Comment on attachment 8360759 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/314

Excellent! We really needed that fixed.
Attachment #8360759 - Flags: review?(bgirard) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Master: 9a89ff827e4ec1ff3278b6ff061b86ec585e715d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
You need to log in before you can comment on or make changes to this bug.