921185 - qHD buchet value is wrong for Windows Firefox OS Simulator

Status: RESOLVED WORKSFORME

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

This mobile-only (qHD) app is not showing up in search results for a user using the Firefox OS simulator. This is apparently because qHD is getting misrecorded on Windows:

https://github.com/mozilla/fireplace/blob/master/hearth/media/js/buckets.js#L75

    12:57 < Nefzaoui> for the simulator, 1.2 pre6
    12:57 < Nefzaoui> and latest daily builds
    12:57 < Nefzaoui> using Windows 8..

Interestingly,

    In [1]: from mkt.webapps.models import FeatureProfile

    # Mac OS X - Firefox OS Simulator 4.0 (ashes: ae5ad)
    In [2]: dict(FeatureProfile.from_signature('1f5fbee9839b.45.2'))['qhd']
    Out[2]: True

    # Windows (ashes: 5fc33)
    In [3]: dict(FeatureProfile.from_signature('1f5eaa1fc3db.45.2'))['qhd']
    Out[3]: False

Basta, Potch, ideas here?

Comment 1

[Matt Basta [:basta]]

Can you get the window.screen values for the windows simulator?

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Matt Basta [:basta] from comment #1)
> Can you get the window.screen values for the windows simulator?

window.screen.availWidth
    1366
window.screen.availHeight
    728
window.screen.width
    1366
window.screen.height
    768
window.screen.colorDepth
    24
window.screen.pixelDepth
    24
window.screen.top
    0
window.screen.left
    0
window.screen.availTop
    0
window.screen.availLeft
    0

Comment 3

[Matt Basta [:basta]]

Are those the values from inside the simulator? On my Windows machine here, `window.screen` is what I'd expect it to be (320x480) and qHD is set to True in the feature profile.

If those values are indeed from inside the simulator, that's a simulator bug.

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

No these are values from a daily desktop build. fxos_1_2_simulator-6.0pre4-win32.xpi does not have a marketplace app, though, entering debug mode on what is meant to be marketplace website from the simulator (through the browser app) gives these values.

window.screen.width
    320
window.screen.height
    480

No marketplace app to test from :)

Comment 5

[Matt Basta [:basta]]

Can you provide the feature profile from the debug page where you got those screen values?

Comment 6

[Ahmed Nefzaoui [:Nefzaoui]]

Feature Profile 1f5eaa3fc3db.45.2

Comment 7

[Matt Basta [:basta]]

That feature profile has qHD set to true.

I'm going to mark this as WFM; I really don't think there's anything wrong here. If you can get the simulator to report something other than 320x480, please file that against github.com/mozilla/r2d2b2g/issues. If there's still a filtering problem (as mentioned in comment #0), please file a new bug with reliable STR.