921239 - ./mach mochitest-plain --repeat doesn't work

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Eric Faust [:efaust]]

Invocations of a single test yield the following results.

[15:21]efaust@firebird:~/m-inlining [hg:try]$ MOZCONFIG=./.moz-tbpl-real-d ./mach mochitest-plain content/base/test/test_bug338679.html --repeat 2
 0:00.18 INFO | automation.py | Launching: /home/efaust/m-inlining/obj-tbpl-no-opt/dist/bin/xpcshell -g /home/efaust/m-inlining/obj-tbpl-no-opt/dist/bin -v 170 -f /home/efaust/m-inlining/obj-tbpl-no-opt/_tests/testing/mochitest/httpd.js -e "const _PROFILE_PATH = '/tmp/tmpiY1dq1'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;" -f ./server.js
Mochitest INFO | runtests.py | Server pid: 4981
 0:01.19 INFO | automation.py | Launching: /usr/bin/python /home/efaust/m-inlining/obj-tbpl-no-opt/_tests/testing/mochitest/pywebsocket_wrapper.py -p 9988 -w /home/efaust/m-inlining/obj-tbpl-no-opt/_tests/testing/mochitest -l /home/efaust/m-inlining/obj-tbpl-no-opt/_tests/testing/mochitest/websock.log --log-level=debug --allow-handlers-outside-root-dir
Mochitest INFO | runtests.py | Websocket server pid: 4995
Error running mach:

    ['mochitest-plain', 'content/base/test/test_bug338679.html', '--repeat', '2']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'Mochitest' object has no attribute 'PLAIN_LOOP_PATH'

  File "/home/efaust/m-inlining/testing/mochitest/mach_commands.py", line 405, in run_mochitest_plain
    return self.run_mochitest(test_file, 'plain', **kwargs)
  File "/home/efaust/m-inlining/testing/mochitest/mach_commands.py", line 448, in run_mochitest
    **kwargs)
  File "/home/efaust/m-inlining/testing/mochitest/mach_commands.py", line 270, in run_desktop_test
    result = runner.runTests(options)
  File "/home/efaust/m-inlining/obj-tbpl-no-opt/_tests/testing/mochitest/runtests.py", line 565, in runTests
    testURL = self.buildTestPath(options)
  File "/home/efaust/m-inlining/obj-tbpl-no-opt/_tests/testing/mochitest/runtests.py", line 285, in buildTestPath
    testURL = ("/").join([testHost, self.PLAIN_LOOP_PATH])

Comment 1

[cajbir (:cajbir)]

Attachment: Fix

This bug seems to have been introduced from bug 865349. That bug reintroduced the use of PLAIN_LOOP_PATH which was removed in a previous bug. This fix reinstates the original line and mochitest-plain repeats work.

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 810938 [details] [diff] [review]
Fix

Review of attachment 810938 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!

Comment 3

[cajbir (:cajbir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/463b7dd0a72f

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/463b7dd0a72f