using android libinput.so and libandroidfw.so for libui

RESOLVED WONTFIX

Status

()

RESOLVED WONTFIX
5 years ago
2 months ago

People

(Reporter: viralwang, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
It's an idea of using libinput.so and libandroidfw.so directly without porting it in gecko. Few benefits for this change:

1) It should reduce the porting effort to merge the code when we've got new Android, we don't need to do any of version check in gecko for different versions support.
2) partners can use their own code if they would like to have any of changing included, we won't need to consider the different driver supported in gecko side.
(Reporter)

Comment 1

5 years ago
Hi Michael,

Could you please kindly give us some feedback for this bug?
Thank you.
Flags: needinfo?(mwu)

Comment 2

5 years ago
libui doesn't do any version checks. It's the opposite - using libinput and other libraries will increase the amount of work we need to do when porting to new Android, because the eventhub/inputreader/etc. interfaces change.

It's also good to maintain a single standard and making sure vendors code against it. I don't believe there is a compelling reason for changing that piece of code without our review. (caf did this, broke all sorts of assumptions and made porting harder than it should've been)

There's yet another issue - stock eventhub/inputreader code uses sprite controller, which attempts to talk to surfaceflinger. Our version of the code has this dependency stripped out.
Flags: needinfo?(mwu)
(Reporter)

Comment 3

5 years ago
Hi Michael,

in bug 910239, we found touch driver reported the events are all hoveringIdBits and it will be malfunction in flatfish. We figure that they have a workaround in aosp inputreader to make it work.

I think we should not put the workaround in our gecko.
Another proposal will be using gonk-patches, and the workaround in gecko can apply for flatfish only.

Could you please give us some suggestion?
Thank you!
Flags: needinfo?(mwu)

Comment 4

5 years ago
Sounds like they never configured the touchscreen. Run adb shell getevent to determine the name of of the touchscreen, and then create a corresponding idc file in /system/usr/idc . For example, if the name is melfas_ts, make a file named melfas_ts.idc in /system/usr/idc that looks like https://github.com/mozilla-b2g/device-inari/blob/master/touchscreen.idc
Flags: needinfo?(mwu)
Closing as we are not working on Firefox OS anymore.
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.