Compiler warning: not enough actual parameters for macro 'ENSURE_NOT_CHILD_PROCESS_

RESOLVED FIXED in mozilla27

Status

()

--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

Trunk
mozilla27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 810956 [details] [diff] [review]
0001-Bug-XXX-fix-compiler-warning-about-not-enough-args-t.patch

A trivial problem, but still worth fixing IMO.

3:43.35 Warning: C4003 in o:\src\mozilla-git\central2\extensions\cookie\nsPermissionManager.cpp: not enough actual parameters for macro 'ENSURE_NOT_CHILD_PROCESS_'
 3:43.35 o:/src/mozilla-git/central2/extensions/cookie/nsPermissionManager.cpp(1683) : warning C4003: not enough actual parameters for macro 'ENSURE_NOT_CHILD_PROCESS_'

Attaching a trivial fix which seems to work on all platforms: https://tbpl.mozilla.org/?tree=Try&rev=83f1fa4e659a

Flagging Benjamin for review as blame says he is the most recent author of non-trivial changes in that file.
Attachment #810956 - Flags: review?(benjamin)
(Assignee)

Comment 1

5 years ago
(In reply to Mark Hammond (:markh) from comment #0)
> Attaching a trivial fix which seems to work on all platforms:
> https://tbpl.mozilla.org/?tree=Try&rev=83f1fa4e659a

Doh - that's an opt-only try.  Debug-only one at https://tbpl.mozilla.org/?tree=Try&rev=3976efa049d3

Updated

5 years ago
Attachment #810956 - Flags: review?(benjamin) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ba6768e46fe
Assignee: nobody → mhammond
Status: NEW → ASSIGNED

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/5ba6768e46fe
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.