921377 - E.me Collection name translation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ran Ben Aharon [:ranbena] EverythingMe]

A new Collection has been added to the homescreen which needs translation for the name in "ar" and "zh-TW"
https://github.com/EverythingMe/gaia/blob/15e0743b3f93b090c4826f4bbf1287c5af2cc203/apps/homescreen/collections/entertainment/manifest.collection

Comment 1

[Axel Hecht [:Pike]]

We don't support translation of files like "manifest.collection".

Why would you want to introduce a new location and format of localizable strings?

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

A Collection is a new type of grid icon, which like grid apps, should be able to have it's label updated when changing OS language.
A manifest.collection file for Collections is no different than a manifest.webapp file for Apps.

(This feature has already landed in master and is intended for koi)

Comment 3

[Axel Hecht [:Pike]]

Landing code and the asking us to support it is not OK.

We're not localizing manifest.webapp, we're localizing a .properties file that lives elsewhere and then build processes in multilocale.py

I suggest that you rewrite your code such that our localization infrastructure supports it.

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Perhaps I'm missing something here.
The Calendar app, for instance, has translations for it's name in it's manifest file (4 languages in master).
https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/manifest.webapp#L22
These translations are for the icon label only.

Collections work the same way. We're missing 2 name translations for a certain Collection and I thought you might help us with that.

Comment 5

[Axel Hecht [:Pike]]

See my post in .gaia on why this is not the same thing.

Comment 6

[chris hofmann]

Hi Ran,

Axel's off-line for a bit over the weekend euro time.  Are you able to sort things out from Axel's mention of https://groups.google.com/forum/#!topic/mozilla.dev.gaia/s3rYC7_tvb4 and links there to how the build system and translation process works?

Is there another gaia engineer that you've been working with that can help sort this out and answer questions?

Comment 7

[Axel Hecht [:Pike]]

I've found that https://github.com/mozilla-b2g/gaia/blob/master/build/applications-data.js reads manifest.collections. Sadly I don't know what that actually does. Can someone help me with that?

Looking at the incoming data to that, there are basically two ways forward:

Make applications-data.js read directly from .properties files. That'd be preferred. As multilocale.py is run before that, you can assume that apps/homescreen/.../collections.*.properties would be there for you to consume. I.e.
apps/homescreen/locales/collections.en-US.properties as
local = Local
games = Games
... etc would generate the required files. applications-data.js probably would want to read LOCALES_FILE from the config, and iterate over the list of locales in that file.

or

Make multilocale.py generate manipulated manifest.collection similar to what it does for manifest.webapp. That had the downside that we'd also needed a patch to gaiaconv, https://bitbucket.org/pike/gaiaconv/.

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

This patch retrieves the translations for collections from properties files so our code is localizable

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 812538 [details]
Patch v1

Thanks, this should work like charm for l10n.

Comment 10

[Amir Nissim (:amirn)]

do we still need the `locales` field in the collections' manifest files?

Comment 11

[Axel Hecht [:Pike]]

(In reply to Amir Nissim (Everything.me) from comment #10)
> do we still need the `locales` field in the collections' manifest files?

I had the same question in an email reply, forgot to add it here. I guess keeping them around would be confusing.

Comment 12

[Cristian Rodriguez (:crdlc)]

We don't need the locales in collection's manifest although we don't parse them so I didn't remove them because I don't know if we will recover that approach in 1.3 for example

Comment 13

[Cristian Rodriguez (:crdlc)]

But if you want I can remove locales from manifest files

Comment 14

[Cristian Rodriguez (:crdlc)]

OK, I gonna remove locales form manifest files

Comment 15

[Cristian Rodriguez (:crdlc)]

done

Comment 16

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/ecb96ae9f7a830512278e1cdf0828b263fb6a38c

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 ecb96ae9f7a830512278e1cdf0828b263fb6a38c
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 18

[Jason Smith [:jsmith]]

Per a recent release drivers discussion, we need to hold off on uplifting this to 1.2 until we confirm a path forward post the planned e.me 1.2 status meeting tomorrow.

Comment 19

[Jason Smith [:jsmith]]

Clearing nom - we're no longer taking e.me 1.2 feature changes to 1.2.