921383 - [Cost Control] Cannot detect zero balance with a Movistar Peru prepaid SIM card

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marcelino Veiga Tuimil [:sonmarce]]

Steps to reproduce:
1. Take a Movistar Peru prepaid SIM card with non-zero balance available
2. Check current balance with Cost Control app
3. Make some phone calls or send SMS until you have zero balance
4. Check current balance again with Cost Control app

Expected result: Cost Control shows zero balance remaining

Actual result: Cost Control shows non-zero balance remaining

Comment 1

[Marcelino Veiga Tuimil [:sonmarce]]

This bug was detected in version 1.1, and must be fixed in the same version, otherwise a Movistar Peru prepaid user with zero balance will see a wrong non-zero remaining balance, then no need for a top-up yet

Comment 2

[Marina Rodríguez [:mai]]

Attachment: Patch v1 - Detect zero balance sms (movistar perú)

Tested successfully on my terminal.

Comment 3

[Salvador de la Puente González [:salva]]

You have some comments on GitHub, as we learn from Borja the other day ;), I'm removing your r?. Ask for it again once you review the patch.

Thank you.

Comment 4

[Marina Rodríguez [:mai]]

Comment on attachment 811062 [details]
Patch v1 - Detect zero balance sms (movistar perú)

Updated changes, thanks for review my code.

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 811062 [details]
Patch v1 - Detect zero balance sms (movistar perú)

Seems OK. Cannot test a real case since Peru service is not available in Spain.

Thank you Mai!

Comment 6

[Salvador de la Puente González [:salva]]

Master: 597b217834474b64b2c2bf786ee974823b3d01f4

Comment 7

[Preeti Raghunath(:Preeti)]

minus for now. Please re-nom when Peru service in Spain is available.

Comment 8

[Marcelino Veiga Tuimil [:sonmarce]]

I think there was a misunderstanding, Salva said he could not tested it from Spain, because it does not work in roaming. But this is for Movistar Peru and we are going to test it from Peru, that it is a target country for version 1.1. So renominating as leo?

Comment 9

[Jason Smith [:jsmith]]

Mass-modify - removal of no longer relevant blocking flags.