Closed Bug 921402 Opened 6 years ago Closed 6 years ago

B2G RIL: Use nsIIccProvider to get iccInfo

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(3 files, 3 obsolete files)

+++ This bug was initially created as a clone of Bug #875721 +++

In bug 875721, we move iccInfo from nsIMobileConnectionProvider to nsIIccProvider. Some module should have to do corresponding changes, like,

dom/phonenumberutils/PhoneNumberUtils.jsm [1]
dom/push/src/PushService.jsm [2]
dom/apps/src/OperatorApps.jsm [3]

[1] http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/OperatorApps.jsm#93
[2] http://mxr.mozilla.org/mozilla-central/source/dom/push/src/PushService.jsm#1489
[3] http://mxr.mozilla.org/mozilla-central/source/dom/phonenumberutils/PhoneNumberUtils.jsm#50
Assignee: nobody → echen
It works well currently is because RILContentHelper implements both nsIMobileConnectionProvider and nsIIccProvider [1]. But I think we should correct this anyway. Thanks.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RILContentHelper.js#446
Patch for PhoneNumberUtils
Patch for PushService
Patch for OperatorApps
Comment on attachment 811041 [details] [diff] [review]
Part 1: [PhoneNumberUtils] Use nsIIccProvider to get iccInfo, v1

Hi Gregor, needs your help to review PhoneNumberUtils, thanks.
Attachment #811041 - Flags: review?(anygregor)
Comment on attachment 811042 [details] [diff] [review]
Part 2: [PushService] Use nsIIccProvider to get iccInfo, v1

Hi Nikhil, needs your help to review PushService, thanks.
Attachment #811042 - Flags: review?(nsm.nikhil)
Comment on attachment 811043 [details] [diff] [review]
Part 3: [OperatorApps] Use nsIIccProvider to get iccInfo, v1

Hi Fabrice, needs your help to review OperatorApps, thanks.
Attachment #811043 - Flags: review?(fabrice)
Comment on attachment 811042 [details] [diff] [review]
Part 2: [PushService] Use nsIIccProvider to get iccInfo, v1

Review of attachment 811042 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!
Attachment #811042 - Flags: review?(nsm.nikhil) → review+
Attachment #811041 - Flags: review?(anygregor) → review+
Attachment #811043 - Flags: review?(fabrice) → review+
Add r=gwagner after r+ by Gregor.
Attachment #811041 - Attachment is obsolete: true
Attachment #811790 - Flags: review+
Add r=nsm after r+ by Nikhil.
Attachment #811042 - Attachment is obsolete: true
Attachment #811792 - Flags: review+
Add r=fabrice after r+ by Fabrice.
Attachment #811043 - Attachment is obsolete: true
Attachment #811793 - Flags: review+
You need to log in before you can comment on or make changes to this bug.