921402 - B2G RIL: Use nsIIccProvider to get iccInfo

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

+++ This bug was initially created as a clone of Bug #875721 +++

In bug 875721, we move iccInfo from nsIMobileConnectionProvider to nsIIccProvider. Some module should have to do corresponding changes, like,

dom/phonenumberutils/PhoneNumberUtils.jsm [1]
dom/push/src/PushService.jsm [2]
dom/apps/src/OperatorApps.jsm [3]

[1] http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/OperatorApps.jsm#93
[2] http://mxr.mozilla.org/mozilla-central/source/dom/push/src/PushService.jsm#1489
[3] http://mxr.mozilla.org/mozilla-central/source/dom/phonenumberutils/PhoneNumberUtils.jsm#50

Comment 1

[Edgar Chen [:edgar]]

It works well currently is because RILContentHelper implements both nsIMobileConnectionProvider and nsIIccProvider [1]. But I think we should correct this anyway. Thanks.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RILContentHelper.js#446

Comment 2

[Edgar Chen [:edgar]]

Attachment: Part 1: [PhoneNumberUtils] Use nsIIccProvider to get iccInfo, v1

Patch for PhoneNumberUtils

Comment 3

[Edgar Chen [:edgar]]

Attachment: Part 2: [PushService] Use nsIIccProvider to get iccInfo, v1

Patch for PushService

Comment 4

[Edgar Chen [:edgar]]

Attachment: Part 3: [OperatorApps] Use nsIIccProvider to get iccInfo, v1

Patch for OperatorApps

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 811041 [details] [diff] [review]
Part 1: [PhoneNumberUtils] Use nsIIccProvider to get iccInfo, v1

Hi Gregor, needs your help to review PhoneNumberUtils, thanks.

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 811042 [details] [diff] [review]
Part 2: [PushService] Use nsIIccProvider to get iccInfo, v1

Hi Nikhil, needs your help to review PushService, thanks.

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 811043 [details] [diff] [review]
Part 3: [OperatorApps] Use nsIIccProvider to get iccInfo, v1

Hi Fabrice, needs your help to review OperatorApps, thanks.

Comment 8

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 811042 [details] [diff] [review]
Part 2: [PushService] Use nsIIccProvider to get iccInfo, v1

Review of attachment 811042 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 9

[Edgar Chen [:edgar]]

Try server: https://tbpl.mozilla.org/?tree=Try&rev=514692adebf2

Comment 10

[Edgar Chen [:edgar]]

Attachment: Part 1: [PhoneNumberUtils] Use nsIIccProvider to get iccInfo, v1, r=gwagner

Add r=gwagner after r+ by Gregor.

Comment 11

[Edgar Chen [:edgar]]

Attachment: Part 2: [PushService] Use nsIIccProvider to get iccInfo, v1, r=nsm

Add r=nsm after r+ by Nikhil.

Comment 12

[Edgar Chen [:edgar]]

Attachment: Part 3: [OperatorApps] Use nsIIccProvider to get iccInfo, v1, r=fabrice

Add r=fabrice after r+ by Fabrice.

Comment 13

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/338f2211d72f
https://hg.mozilla.org/integration/b2g-inbound/rev/4e79d5ce1587
https://hg.mozilla.org/integration/b2g-inbound/rev/fd005afd602e

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/338f2211d72f
https://hg.mozilla.org/mozilla-central/rev/4e79d5ce1587
https://hg.mozilla.org/mozilla-central/rev/fd005afd602e