921409 - PDF viewer in Firefox 24 is broken (displaying just garbage) - version 23 and below were ok

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P2)

Description

[Frederic Steinfels]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130910160258

Steps to reproduce:

Opened one of my self-created PDF's
https://www.highdefinition.ch/pdf/open/xWmAMrfh/receipt_130919005.pdf


Actual results:

Version 23 of FF and below: ok
Version 24 of FF: just garbage


Expected results:

It should work as in version 23 of Firefox

Comment 1

[Jonas Jenwald [:Snuffleupagus]]

According to 'git bisect', this regressed upstream in: https://github.com/mozilla/pdf.js/pull/3187.

Comment 2

[Loic]

Regression range:
good=2013-05-17
bad=2013-05-18
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ea767da526ff&tochange=6e2789a70f6b

Ryan VanderMeulen — Bug 871530 - Update pdf.js to version 0.8.169. r=dtownsend
and likely
#3187 Fix glyph selection for CID fonts that don't actually have CID font files.

Comment 3

[Loic]

Attachment: receipt_94659.pdf

For the record.

Comment 4

[Andreas Toom]

We are seeing the same thing for all our pdfs, worked perfectly in FF 23.

Comment 5

[Alex Keybl [:akeybl]]

Definitely worth targeting a fix for FF25, given how recent this regression is. Brendan, would you mind taking a look?

Comment 6

[Brendan Dahl [:bdahl]]

Andreas, can you provide a link to some of your pdfs so I can confirm it is the same issue?

Comment 7

[Andreas Toom]

Attachment: PDF version of a typical invoice that we present to our customers

An example PDF file that does not render properly in FF 24 but worked in FF 23 as requested by Brendan.

/Andreas

Comment 8

[Loic]

(In reply to Andreas Toom from comment #7)
> Created attachment 812589 [details]
> PDF version of a typical invoice that we present to our customers
> 
> An example PDF file that does not render properly in FF 24 but worked in FF
> 23 as requested by Brendan.
> 
> /Andreas

It's rendered fine on my side. Could you attach a screenshot of the bad rendering, please.

Comment 9

[Andreas Toom]

Attachment: Screenshot of customer pdf viewed in ff 24

As requested, a screenshot of the pdf viewed inside FF 24.

Comment 10

[Frederic Steinfels]

> As requested, a screenshot of the pdf viewed inside FF 24.

This PDF is rendered correctly on my FF 24. It must be a different problem.

Comment 11

[Andreas Toom]

(In reply to Frederic Steinfels from comment #10)
> > As requested, a screenshot of the pdf viewed inside FF 24.
> 
> This PDF is rendered correctly on my FF 24. It must be a different problem.

Interestingly the pdf file you attached renders nicely on my FF, could it be something based on locale ?

Comment 12

[Loic]

(In reply to Andreas Toom from comment #9)
> Created attachment 812597 [details]
> Screenshot of customer pdf viewed in ff 24
> 
> As requested, a screenshot of the pdf viewed inside FF 24.

It's on Win XP SP3?

Comment 13

[Andreas Toom]

(In reply to Loic from comment #12)
> (In reply to Andreas Toom from comment #9)
> > Created attachment 812597 [details]
> > Screenshot of customer pdf viewed in ff 24
> > 
> > As requested, a screenshot of the pdf viewed inside FF 24.
> 
> It's on Win XP SP3?

No, Windows 7 Enterprise SP1

Comment 14

[Brendan Dahl [:bdahl]]

@Andreas please file a new bug, it seems to be a separate issue.

Comment 15

[Brendan Dahl [:bdahl]]

Attachment: cid-fix-aurora.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 871530
User impact if declined: certain fonts will no longer render correctly
Testing completed (on m-c, etc.): in m-c
Risk to taking this patch (and alternatives if risky): low risk content js only
String or IDL/UUID changes made by this patch: none

Comment 16

[Brendan Dahl [:bdahl]]

Attachment: cid-fix-beta.patch

[Approval Request Comment]
see above

Comment 17

[Brendan Dahl [:bdahl]]

Woops, jumped the gun there, still needs approval.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2243db5c1a3e
https://hg.mozilla.org/releases/mozilla-beta/rev/9ac4fdef5f52

Will pick up this fix on trunk with the next uplift.

Comment 19

[Mihai Morar, (:MihaiMorar)]

I confirm the fix is verified on Latest Aurora 26 and FF25b8 on Windows 7 x64:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 
BuildID: 20131015004002

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20100101 Firefox/25.0
BuildID: 20131015052812

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Bug 928358 updates pdf.js on trunk to a version containing this fix. It should be merged to m-c later today.

Comment 21

[[:Aleksej]]

Verified fixed with attachment 811159 [details]:
bug: firefox-24.0.en-US.linux64
WFM:
2013-10-20-03-02-02-mozilla-central-firefox-27.0a1.en-US.linux-x86_64
2013-10-29-03-02-01-mozilla-central-firefox-28.0a1.en-US.linux-x86_64

Comment 22

[u279076]

Thanks Aleksej.

Comment 23

[Lukas Blakk [:lsblakk] use ?needinfo]

Nothing from user feedback suggests this is widely being hit in ESR, which has been out for several months now, so we'll let this ride the trains to next ESR