921422 - B2G RIL: include clientId in async messages from RadioInterface to RILContentHelper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Jessica Jong [:jessica] (inactive)]

RadioInterfaceLayer sendWithIPCMessage() [1] only sends the content of "msg.json.data" to RILContentHelper, so clientId is missing. We should wrap clientId and data together and sent it back to RILContentHelper.
This affects all the functions that use sendWithIPCMessage(). 

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#638

Comment 1

[Jessica Jong [:jessica] (inactive)]

Other functions that have the same problem: sendMMI() [1], setCallForwardingOption() [2], setCallingLineIdRestriction() [3] in RadioInterfaceLayer.

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#2293
[2] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#2307
[3] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#2317

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Looks like replacing msg.json.data in [1] with msg.json could fix this issue. 
Will try it later :P

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#639

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 921422.patch

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://tbpl.mozilla.org/?tree=Try&rev=c9aa690a355a looks green except test_icc_contacts.js which has been tracked in Bug 897940. I ran test_icc_contacts.js locally without encountering failures. 

If I take the suggestion from bug 897940 comment 2, the test passes! https://tbpl.mozilla.org/?tree=Try&rev=b9a57895b831

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a7a6db5c2601

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7a6db5c2601