B2G RIL: include clientId in async messages from RadioInterface to RILContentHelper

RESOLVED FIXED in Firefox 28

Status

Firefox OS
RIL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jessica, Assigned: hsinyi)

Tracking

unspecified
1.3 Sprint 2 - 10/11
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:1.3+, firefox28 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
RadioInterfaceLayer sendWithIPCMessage() [1] only sends the content of "msg.json.data" to RILContentHelper, so clientId is missing. We should wrap clientId and data together and sent it back to RILContentHelper.
This affects all the functions that use sendWithIPCMessage(). 

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#638
(Reporter)

Updated

5 years ago
Blocks: 818353
(Assignee)

Updated

5 years ago
Blocks: 818351, 818352
(Assignee)

Comment 2

5 years ago
Looks like replacing msg.json.data in [1] with msg.json could fix this issue. 
Will try it later :P

[1] http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/RadioInterfaceLayer.js#639
(Reporter)

Updated

5 years ago
Summary: B2G RIL: include clientId in callback messages from RadioInterface to RILContentHelper → B2G RIL: include clientId in async messages from RadioInterface to RILContentHelper
(Assignee)

Comment 3

5 years ago
Created attachment 811782 [details] [diff] [review]
921422.patch
Assignee: nobody → htsai
(Assignee)

Updated

5 years ago
Attachment #811782 - Flags: review?(vyang)
(Assignee)

Updated

5 years ago
Attachment #811782 - Flags: review?(vyang)
(Assignee)

Updated

5 years ago
Attachment #811782 - Flags: review?(vyang)
Attachment #811782 - Flags: review?(vyang) → review+
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=c9aa690a355a looks green except test_icc_contacts.js which has been tracked in Bug 897940. I ran test_icc_contacts.js locally without encountering failures. 

If I take the suggestion from bug 897940 comment 2, the test passes! https://tbpl.mozilla.org/?tree=Try&rev=b9a57895b831
https://hg.mozilla.org/mozilla-central/rev/a7a6db5c2601
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 926343

Updated

5 years ago
blocking-b2g: --- → 1.3+
Target Milestone: --- → 1.3 Sprint 2 - 10/11
status-firefox28: --- → fixed
You need to log in before you can comment on or make changes to this bug.