921440 - Build ASan optimized builds with -gline-tables-only to reduce file sizes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Christian Holler (:decoder)]

Currently, all ASan builds are built with debug symbols and remain unstripped, which is why the resulting builds are so large in file size. While it's necessary for debugging these builds (which is even required sometimes with ASan), at least the optimized builds don't behave very well in a debugger anyway, so we can as well build them with -gline-tables-only to just leave the necessary information in the builds that is required for symbolizing ASan traces. This should reduce the file size from ~336M down to ~111M according to my try run. The unstripped tests will be at ~190M (stripped are ~159M for now, unstripped would be much larger).

I also verified that we can still symbolize traces using the new builds. Patch coming.

Comment 1

[Christian Holler (:decoder)]

Attachment: asan-gline-tables-only.patch

Use -gline-tables-only instead of -g for linux64 ASan release builds.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 811075 [details] [diff] [review]
asan-gline-tables-only.patch

Review of attachment 811075 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/config/mozconfigs/linux64/nightly-asan
@@ +1,3 @@
>  # We still need to build with debug symbols
>  ac_add_options --disable-debug
> +ac_add_options --enable-optimize="-O2 -gline-tables-only"

Any reason this isn't --enable-debug-symbols="-gline-tables-only" ?

Comment 3

[Christian Holler (:decoder)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c868eb8d83fd

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c868eb8d83fd