Closed Bug 921446 Opened 11 years ago Closed 11 years ago

Duplicate notes are displayed when View Older button is pressed in thread notes page

Categories

(Marketplace Graveyard :: Admin Tools, defect, P3)

Product:
Marketplace Graveyard
Component:
Admin Tools
Platform:
x86_64
Windows 7
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2013-12-17

People

(Reporter: julian.mozbugs, Assigned: kngo)

References

Details

Steps to reproduce:
1. Load Communication Dashboard landing page https://marketplace-dev.allizom.org/comm/
2. Click on "# notes" link from a listed app that has more than 6 notes added.
3. Click the View Older button.

Expected results:
The notes that are not visible, are displayed in the list and no duplicates are shown.

Actual results:
The notes displayed above the View Older button, are duplicated after it's pressed. Only after the second press of the button, the other notes are shown.

Notes/Issues:
Verified on FF27 (Win 7).
Screencast for this issue http://screencast.com/t/fog8FfpFt
Priority: -- → P3
Please note that even if the rest of notes are visible after the second press of "View older" the duplicates are still there.
Assignee: nobody → kngo
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Target Milestone: --- → 2013-12-10
This issue is still reproducing in https://marketplace-dev.allizom.org/comm/ on FF28 (Win 7).
Please see screencast http://screencast.com/t/Kix2Lzv8u4j
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Could you try on a thread with fresh notes? That may have been duplicate notes being created in the backend months ago. Thanks!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Flags: needinfo?(iulian.timis)
Resolution: --- → WORKSFORME
I just added new notes to a new thread and I can consistently reproduce this issue. Please see screencast http://screencast.com/t/eU42neh9m
Status: RESOLVED → REOPENED
Flags: needinfo?(iulian.timis)
Resolution: WORKSFORME → ---
Could be a variant of bug 948084 but comm APIs do inherit from MarketplaceView so they should be paginated correctly. Maybe double-check that though.
It was a JS problem.

What confused me was the initial issue (on the comm main page) was resolved, but an identical issue (on the thread detail page) came back that was caused by something else.

https://github.com/mozilla/commbadge/pull/36

Thanks Iulian (should be fixed now).
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: 2013-12-10 → 2013-12-17
Thanks Kevin!
Verified as fixed in https://marketplace-dev.allizom.org/comm on FF29 (Win 7).
Postfix screencast http://screencast.com/t/gffGfRVs
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.