921453 - WebIDL.py should reject ChromeOnly, Pref, PrefControlled, and Func extended attributes if [NoInterfaceObject] is also present

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

See bug 901114.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Probably better done in Codegen.py.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't allow conditional-exposure annotations on an interface that has no interface object, since they make no sense there

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't allow conditional-exposure annotations on an interface that has no interface object, since they make no sense there

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/af6fa89ec550

And a followup for b2g-only silliness:

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a56d8b3d613

Kyle, mind looking over that one to make sure I'm not missing something?

Comment 5

[Reuben Morais [:reuben]]

Comment on attachment 8476093 [details] [diff] [review]
Don't allow conditional-exposure annotations on an interface that has no interface object, since they make no sense there

Review of attachment 8476093 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/parser/WebIDL.py
@@ +1013,5 @@
>                                self.parentScope.primaryGlobalName,
>                                [self.location])
>  
> +        # Conditional exposure makes no sense for interfaces with no
> +        # interface object, unless they're navigator properties.

What about something like

  [NoInterfaceObject, Constructor, CheckPermissions]
  interface Foo {};

Comment 6

[Boris Zbarsky [:bzbarsky]]

NoInterfaceObject and Constructor couldn't be used together even before the changes in this bug, since NoInterfaceObject means the object that Constructor would make into a constructor doesn't even exist.

Comment 7

[Reuben Morais [:reuben]]

This never worked, but if the intention of CheckPermission and AvailableIn there was to conditionally expose startPoll/powerOff/etc in MozNFC, the annotations should be added directly to those methods.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af6fa89ec550
https://hg.mozilla.org/mozilla-central/rev/4a56d8b3d613

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Thanks Reuben for reporting this,
We have found this problem in Bug 1054139 (The current r+ patches will be updated again) and will fix it there.
Thanks

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Yoshi Huang[:allstars.chh] from comment #9)
> Thanks Reuben for reporting this,
> We have found this problem in Bug 1054139
Will move the Bug 1061055.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

lgtm.