Closed
Bug 921478
Opened 9 years ago
Closed 9 years ago
Remove BackstagePass IDB constructor resolve hook and use Cu.importGlobalProperties
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: bholley, Assigned: vendo)
References
Details
Attachments
(3 files, 3 obsolete files)
34.23 KB,
patch
|
bholley
:
review+
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
2.86 KB,
patch
|
Details | Diff | Splinter Review | |
24.21 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Jan promised to rip out the resolve hook machinery from bug 920179 and use the Cu.importGlobalProperties machinery from bug 920553. He's going to land IDBKeyRange using the existing resolve hook for now (since it's a Q3 goal), and then fix this all up sometime next week.
Comment 2•9 years ago
|
||
Bobby, sorry I know that I promised to fix this ASAP, but I've been extremely busy with wrapping up sync IDB for review. Anyway, Vendo is willing to finish my 90% complete patch for this bug. The only thing that needs to be done is to rewrite test_contact_upgrade.html to XUL. I explained the problem to him in person.
Assignee: Jan.Varga → vendo.ruzicka
Flags: needinfo?(Jan.Varga)
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Conversion of test_contacts_upgrade.html to chrome mochitest. Try https://tbpl.mozilla.org/?tree=Try&rev=532ff0f32eeb
Assignee | ||
Comment 5•9 years ago
|
||
Diff including Patch part 2 with ignore white space option (-w) for better visibility of changes.
Comment 6•9 years ago
|
||
Vendo, dom/datastore has been added in the meantime, I think we need to add |Cu.importGlobalProperties(["indexedDB"])| after |Cu.import("resource://gre/modules/XPCOMUtils.jsm");| in dom/datastore/DataStoreDB.jsm
Updated•9 years ago
|
Attachment #823550 -
Attachment is patch: true
Attachment #823550 -
Attachment mime type: text/x-patch → text/plain
Assignee | ||
Comment 7•9 years ago
|
||
done, tests running at https://tbpl.mozilla.org/?tree=Try&rev=9243a9dbf43a
Attachment #823546 -
Attachment is obsolete: true
Comment 8•9 years ago
|
||
Comment on attachment 823300 [details] [diff] [review] patch Review of attachment 823300 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/indexedDB/test/unit/xpcshell.ini @@ +31,3 @@ > [test_globalObjects_ipc.js] > # FIXME/bug 575918: out-of-process xpcshell is broken on OS X > +#skip-if = os == "mac" || os == "android" note, this needs to be uncommented
Assignee | ||
Comment 9•9 years ago
|
||
updated, now it should be ok https://tbpl.mozilla.org/?tree=Try&rev=3731a184126a
Attachment #824199 -
Attachment is obsolete: true
Updated•9 years ago
|
Attachment #823300 -
Flags: review?(bobbyholley+bmo)
Attachment #823300 -
Flags: review?(bent.mozilla)
Updated•9 years ago
|
Attachment #824558 -
Flags: review?(bent.mozilla)
Comment 10•9 years ago
|
||
Comment on attachment 824558 [details] [diff] [review] patch part 2 Review of attachment 824558 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/contacts/tests/test_contacts_upgrade.xul @@ +8,2 @@ > > +<window title="Mozilla Bug 889239" All 889239 should be changed to 921478 in this test
Assignee | ||
Comment 11•9 years ago
|
||
bug numbers in test updated
Attachment #824558 -
Attachment is obsolete: true
Attachment #824558 -
Flags: review?(bent.mozilla)
Attachment #824583 -
Flags: review?(bent.mozilla)
Updated•9 years ago
|
Attachment #824558 -
Attachment is obsolete: false
Attachment #824558 -
Flags: review?(bent.mozilla)
Comment 12•9 years ago
|
||
Comment on attachment 824583 [details] [diff] [review] patch part 2 Sorry for the spam, I take back my comment about changing the bug number in the test (it was too early in the morning), sorry again.
Attachment #824583 -
Attachment is obsolete: true
Attachment #824583 -
Flags: review?(bent.mozilla)
Reporter | ||
Comment 13•9 years ago
|
||
Comment on attachment 823300 [details] [diff] [review] patch Review of attachment 823300 [details] [diff] [review]: ----------------------------------------------------------------- I'll let bent review the IDB testing changes. r=bholley on the rest. ::: dom/indexedDB/IndexedDatabaseManager.cpp @@ +424,5 @@ > + !IDBObjectStoreBinding::GetConstructorObject(aCx, aGlobal) || > + !IDBOpenDBRequestBinding::GetConstructorObject(aCx, aGlobal) || > + !IDBRequestBinding::GetConstructorObject(aCx, aGlobal) || > + !IDBTransactionBinding::GetConstructorObject(aCx, aGlobal) || > + !IDBVersionChangeEventBinding::GetConstructorObject(aCx, aGlobal)) { uber nit - brace on its own line due to the lack of visual separation from a multiline condition. The Gecko style guide is silent on this issue, but the SM style guide describes it pretty explicitly: https://wiki.mozilla.org/JavaScript:SpiderMonkey:C_Coding_Style#Other_whitespace
Attachment #823300 -
Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 823300 [details] [diff] [review] patch Review of attachment 823300 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! Sorry for the delay.
Attachment #823300 -
Flags: review?(bent.mozilla) → review+
Attachment #824558 -
Flags: review?(bent.mozilla) → review+
Comment 15•9 years ago
|
||
rebased and pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/5cda44ae1ba0 https://hg.mozilla.org/integration/mozilla-inbound/rev/e07cab8a2732
Comment 16•9 years ago
|
||
(In reply to Jan Varga [:janv] from comment #15) > rebased and pushed > > https://hg.mozilla.org/integration/mozilla-inbound/rev/5cda44ae1ba0 > https://hg.mozilla.org/integration/mozilla-inbound/rev/e07cab8a2732 Hi Jan, had to backout this changes in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=282c409d2a35 because of perma failures/oranges like https://tbpl.mozilla.org/php/getParsedLog.php?id=30754893&tree=Mozilla-Inbound in B2G Desktop Linux x64 Opt
Comment 17•9 years ago
|
||
Oh, that test just needs to be disabled on B2G Desktop, I'll do it.
Comment 18•9 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=db759ea9acbd https://hg.mozilla.org/integration/mozilla-inbound/rev/fc6579a5b551 https://hg.mozilla.org/integration/mozilla-inbound/rev/ce8a25e53bda
Comment 19•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fc6579a5b551 https://hg.mozilla.org/mozilla-central/rev/ce8a25e53bda
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 20•9 years ago
|
||
I think we should land this on aurora too, otherwise FF27 will ship with "automatic lazy IDB initialization". See bug 932345.
Let's get the right flags set.
You need to log in
before you can comment on or make changes to this bug.
Description
•