Closed Bug 921492 Opened 6 years ago Closed 6 years ago

make StrictOrderingOnAppendList use actual alphabetical sorting

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: froydnj, Assigned: glandium)

References

Details

Attachments

(2 files, 1 obsolete file)

In fixing bug 921091, I was surprised that moz.build wanted the ordering:

CDATA<stuff>.webidl
CallEvent.webidl

instead of the expected alphabetical ordering.  I know why it wants this, but I submit that it is unusual.

In some ways, this is moot because moz.build tells you how to fix things (++ for that).  But it might be better to not have to fix things in the first place.
Depends on: 913268
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
gps for the sandbox change. Sadly, overloading __builtins__.list doesn't make literal lists ("[1,2,3]") use the overloaded class, which means it's hard to do the same with list.sort().
Attachment #821022 - Flags: review?(mshal)
Attachment #821022 - Flags: review?(gps)
Attachment #821013 - Attachment is obsolete: true
Attachment #821013 - Flags: review?(mshal)
Comment on attachment 821022 [details] [diff] [review]
Make StrictOrderingOnAppendList use actual alphabetical sorting

>+	'PSMContentListener.cpp',

nit: tab instead of spaces

Also, your script seems to preserve comments with the line they were on rather than the filename, so dom/mobilemessage/src/moz.build gets a bit messed up:

-    'MobileMessageService.h', # Required by nsLayoutModule.cpp
-    'SmsServicesFactory.h',   # Required by nsLayoutModule.cpp
-    'Types.h',                # Required by IPDL SmsTypes.h
-    'ipc/SmsChild.h',
-    'ipc/SmsParent.h',
+    'ipc/SmsChild.h', # Required by nsLayoutModule.cpp
+    'ipc/SmsParent.h',   # Required by nsLayoutModule.cpp
+    'MobileMessageService.h',                # Required by IPDL SmsTypes.h
+    'SmsServicesFactory.h',
+    'Types.h',

Eg: MobileMessageService.h used to say "Required by nsLayoutModule.cpp", but now says "Required by IPDL SmsTypes.h"
Attachment #821022 - Flags: review?(mshal) → review+
Attachment #821022 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/b84acd40490e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.