Remove touch event shim from gaia

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c= p=2 s=2013.10.04 u=])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Now that we have touch-events.js inside of /browser/devtools/shared/, we should be able to remove out gaia shim and simply include it from our desktop helper extension. This would be a nice reduction in code.

We will also need to port the fix from bug 920742 into the devtools touch event library.

We should be able to remove this file and the code that includes it:
https://github.com/mozilla-b2g/gaia/blob/master/tools/extensions/desktop-helper/content/touch-events.js
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Whiteboard: [c= p= s= u=] → [c= p=2 s= u=]
(Assignee)

Comment 1

4 years ago
Created attachment 811220 [details]
Github pull request pointer

Paul - could you review this one?
Attachment #811220 - Flags: review?(paul)
(Assignee)

Updated

4 years ago
Blocks: 920742

Updated

4 years ago
Attachment #811220 - Flags: review?(paul) → review+
(Assignee)

Comment 2

4 years ago
Thanks for the review!

Landed in master: https://github.com/mozilla-b2g/gaia/commit/fb758390a5e926b8582816a6cce80804dd802b66
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [c= p=2 s= u=] → [c= p=2 s=2013.10.04 u=]
(Assignee)

Comment 3

4 years ago
Hi Paul,

It appears that I may have broken inputs inside of b2g desktop. I was wondering on what you think the proper way to fix this would be. In the long term, we obviously want pointer events, but for now - we should have a single way of including touch support for b2g desktop, or running in the browser.

I guess I was wondering if you think we should include devtools code within DEBUG builds of b2g desktop, or if we should move this to some place that is included by b2g desktop builds. Thanks!
Flags: needinfo?(paul)

Comment 4

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #3)
> Hi Paul,
> 
> It appears that I may have broken inputs inside of b2g desktop.

That's annoying. We use B2G desktop for the simulator. I'm wondering if we broke touch events in the simulator as well then.

> I was
> wondering on what you think the proper way to fix this would be. In the long
> term, we obviously want pointer events,

What are pointer events? Mouse events?

> but for now - we should have a
> single way of including touch support for b2g desktop, or running in the
> browser. I guess I was wondering if you think we should include devtools code within
> DEBUG builds of b2g desktop, or if we should move this to some place that is
> included by b2g desktop builds. Thanks!

I see. We can easily move the touch-events code to /toolkit/devtools/. This code
is available from B2G desktop.
Flags: needinfo?(paul)

Comment 5

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #3)

Can you file a bug?
Flags: needinfo?(kgrandon)
(Assignee)

Comment 6

4 years ago
(In reply to Paul Rouget [:paul] from comment #5)
> Can you file a bug?

I need to get b2g and verify that it's an issue - I've only just heard reports of it on IRC.
Flags: needinfo?(kgrandon)

Comment 7

4 years ago
Alex, do touch events still work in B2G Desktop? How do we simulate them?
Flags: needinfo?(poirot.alex)
Yes, it broke b2g desktop. The simulator is building gaia with these extra helpers like touch event.
Flags: needinfo?(poirot.alex)
You need to log in before you can comment on or make changes to this bug.