921604 - Signaling unittest trickle tests fail on machines with multiple addresses

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Ethan Hugg [:ehugg]]

Signaling unittests test CreateOfferSetLocalTrickleTestServer fails on my machine with this error:

agent: onSetLocalDescriptionSuccess
agent: onIceCandidate [1/] candidate:3 2 UDP 1686044670 192.0.2.1 1001 typ srflx raddr 192.168.122.1 rport 56985
agent: onIceCandidate [1/] candidate:1 2 UDP 1686110206 192.0.2.1 1001 typ srflx raddr 64.101.40.11 rport 56710
agent: onIceCandidate [1/] candidate:3 1 UDP 1686044671 192.0.2.1 1001 typ srflx raddr 192.168.122.1 rport 41630
agent: onIceCandidate [1/] candidate:1 1 UDP 1686110207 192.0.2.1 1001 typ srflx raddr 64.101.40.11 rport 37856
/home/ehugg/mozilla/third/media/webrtc/signaling/test/signaling_unittests.cpp:2632: Failure
Value of: agent(0)->MatchingCandidates(kBogusSrflxAddress)
  Actual: 4
Expected: 2U
Which is: 2


I believe it's because it's a VM host and has a virtual adapter 192.168.122.1 as well at it's real one 64.101.40.11.

This test is from bug 842549.

Comment 1

[Ethan Hugg [:ehugg]]

Attachment: Fix trickle unittests for machines with multiple addresses

Comment 2

[Adam Roach [:abr]]

Comment on attachment 811359 [details] [diff] [review]
Fix trickle unittests for machines with multiple addresses

Review of attachment 811359 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 3

[Ethan Hugg [:ehugg]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/93ae220f13c9

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/93ae220f13c9