921677 - TypeError when I extract strings from rocketfuel

Status: RESOLVED FIXED

(Marketplace Graveyard :: Code Quality, defect)

Description

[Wil Clouser [:clouserw]]

Ran extract on the rocketfuel repo and got this output:

> Commonplace v0.1.6
> 
> /usr/local/lib/node_modules/commonplace/lib/extract_l10n.js:195
> 	                calls = calls.concat(extract_callextension(arg).map(calls.pus
> 	                                                                ^
> TypeError: Array.prototype.push called on null or undefined
>     at Array.map (native)
>     at /usr/local/lib/node_modules/commonplace/lib/extract_l10n.js:195:66
>     at Array.map (native)
>     at extract_callextension (/usr/local/lib/node_modules/commonplace/lib/extract_l10n.js:190:28)
>     at L10nContext.extract_template (/usr/local/lib/node_modules/commonplace/lib/extract_l10n.js:202:30)
>     at /usr/local/lib/node_modules/commonplace/lib/commonplace.js:325:25
>     at fs.js:266:14
>     at Object.oncomplete (fs.js:107:15)


It worked fine on commbadge and fireplace.

Comment 1

[Matt Basta [:basta]]

This fix makes sense and works for me:

https://github.com/mozilla/commonplace/compare/428d155fa1c1...4405cbc2a4c5

Let me know if you have any problems.