921680 - Poor formatting of JS errors in workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-worker-error-handling

Every time I start up Firefox I get this error on stderr:

reference to undefined property exn.stack

There's no \n after it, so it gets mixed in with other stuff. It turns out a worker is generating it. This patch fixes the formatting of error printing on stderr for workers so we get a filename, line number, and a terminating \n.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 811444 [details] [diff] [review]
fix-worker-error-handling

Review of attachment 811444 [details] [diff] [review]:
-----------------------------------------------------------------

Yay, thanks!

Comment 3

[Andrew McCreight [:mccr8]]

Yay, thanks!  This has been irritating me for quite a while.  I didn't look in workers so I guess that's why I didn't find it.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

It's so sad, that whole error reporting function is so elaborate and then I goofed the last printf...

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/717d363cbd7d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/717d363cbd7d